Attachment 204765 Details for Bug 360210 – fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix

305172 fix to backport.txt (text/plain), 1.68 KB, created by Deepak Azad

on 2011-10-07 12:54:37 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Deepak Azad

Created: 2011-10-07 12:54:37 EDT

Size: 1.68 KB

patch

obsolete

>diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/RefreshAction.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/RefreshAction.java
>index db43651..0387d9a 100644
>--- a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/RefreshAction.java
>+++ b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/RefreshAction.java
>@@ -196,7 +196,7 @@
> 		ArrayList javaElements= new ArrayList();
> 		for (int i= 0; i < selectedElements.length; i++) {
> 			Object curr= selectedElements[i];
>-			if (curr instanceof IJavaElement) {
>+			if (curr instanceof IPackageFragmentRoot) {
> 				javaElements.add(curr);
> 			} else if (curr instanceof PackageFragmentRootContainer) {
> 				javaElements.addAll(Arrays.asList(((PackageFragmentRootContainer) curr).getPackageFragmentRoots()));
>@@ -204,22 +204,14 @@
> 				IAdaptable[] members= ((IWorkingSet) curr).getElements();
> 				for (int k= 0; k < members.length; k++) {
> 					Object adapted= members[k].getAdapter(IJavaElement.class);
>-					if (adapted != null) {
>+					if (adapted instanceof IPackageFragmentRoot) {
> 						javaElements.add(adapted);
> 					}
> 				}
>-			} else if (curr instanceof IAdaptable) {
>-				Object adapted= ((IAdaptable) curr).getAdapter(IJavaElement.class);
>-				if (adapted != null) {
>-					javaElements.add(adapted);
>-				}
> 			}
>  		}
>-		IJavaModel model= JavaCore.create(ResourcesPlugin.getWorkspace().getRoot());
>-		if (selection.isEmpty()) {
>-			javaElements.add(model);
>-		}
> 		if (!javaElements.isEmpty()) {
>+			IJavaModel model= JavaCore.create(ResourcesPlugin.getWorkspace().getRoot());
> 			model.refreshExternalArchives((IJavaElement[]) javaElements.toArray(new IJavaElement[javaElements.size()]), monitor);
> 		}
> 	}

Actions: View | Diff

Attachments on bug 360210: 204765