Attachment 204724 Details for Bug 360152 – Proposed patch for v14_Maintenance branch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch for v14_Maintenance branch

Bug-360152-v1.4.patch (text/plain), 1.47 KB, created by Ivan Furnadjiev

on 2011-10-06 17:56:37 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2011-10-06 17:56:37 EDT

Size: 1.47 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: src/org/eclipse/swt/internal/widgets/tablekit/TableLCA.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/src/org/eclipse/swt/internal/widgets/tablekit/Attic/TableLCA.java,v
>retrieving revision 1.34
>diff -u -r1.34 TableLCA.java
>--- src/org/eclipse/swt/internal/widgets/tablekit/TableLCA.java	1 Mar 2011 11:47:26 -0000	1.34
>+++ src/org/eclipse/swt/internal/widgets/tablekit/TableLCA.java	6 Oct 2011 21:54:35 -0000
>@@ -465,7 +465,7 @@
>         String[] details = cell.split( "," );
>         String itemId = details[ 0 ];
>         int columnIndex = NumberFormatUtil.parseInt( details[ 1 ] );
>-        TableItem item = getItemById( table, itemId );
>+        TableItem item = ( TableItem )WidgetUtil.find( table, itemId );
>         // Bug 321119: Sometimes the client can request tooltips for already
>         //             disposed cells.
>         if(    item != null
>@@ -490,18 +490,6 @@
>     }
>   }
> 
>-  private static TableItem getItemById( final Table table, final String itemId )
>-  {
>-    TableItem result = null;
>-    TableItem[] items = table.getItems();
>-    for( int i = 0; i < items.length && result == null; i++ ) {
>-      if( WidgetUtil.getId( items[ i ] ).equals( itemId ) ) {
>-        result = items[ i ];
>-      }
>-    }
>-    return result;
>-  }
>-
>   //////////////////
>   // Helping methods
>

Flags:

ruediger.herrmann: review+

Actions: View | Diff

Attachments on bug 360152: 204724