Attachment 202603 Details for Bug 356463 – Patch to check for null id and add id of process

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to check for null id and add id of process

z.patch (text/plain), 3.30 KB, created by Marc Khouzam

on 2011-09-01 09:05:44 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Khouzam

Created: 2011-09-01 09:05:44 EDT

Size: 3.30 KB

patch

obsolete

>From 80f8e653dde2bb5363e6dce989a26f85c0512aa4 Thu, 1 Sep 2011 09:02:42 -0400
>From: Marc Khouzam <marc.khouzam@ericsson.com>
>Date: Thu, 1 Sep 2011 09:02:28 -0400
>Subject: [PATCH] Bug 356463: Wrong label in thread filter for programs compiled without pthreads
>
>diff --git a/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/breakpoints/GdbThreadFilterEditor.java b/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/breakpoints/GdbThreadFilterEditor.java
>index 3b4ae72..22cbc9c 100644
>--- a/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/breakpoints/GdbThreadFilterEditor.java
>+++ b/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/breakpoints/GdbThreadFilterEditor.java
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2004, 2009 QNX Software Systems and others.
>+ * Copyright (c) 2004, 2011 QNX Software Systems and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -7,6 +7,7 @@
>  *
>  * Contributors:
>  * QNX Software Systems - Initial API and implementation
>+ * Marc Khouzam (Ericsson) - Check for a null threadId (Bug 356463)
>  *******************************************************************************/
> package org.eclipse.cdt.dsf.gdb.internal.ui.breakpoints;
> 
>@@ -474,7 +475,15 @@
>                             new DataRequestMonitor<IThreadDMData>(ImmediateExecutor.getInstance(), rm) {
>                                 @Override
>                                 public void handleSuccess() {
>-                                	rm.setData(getData().getName());
>+                                    final StringBuilder builder = new StringBuilder(getData().getName());
>+                                    String containerId = getData().getId();
>+                                    if (containerId != null) {
>+                                    	builder.append(" ["); //$NON-NLS-1$
>+                                    	builder.append(containerId);
>+                                    	builder.append("]"); //$NON-NLS-1$
>+                                    }
>+ 
>+                                	rm.setData(builder.toString());
>                                 	rm.done();
>                                 }
>                             });
>@@ -524,8 +533,14 @@
>                             builder.append("["); //$NON-NLS-1$
>                             builder.append(((IMIExecutionDMContext)thread).getThreadId());
>                             builder.append("] "); //$NON-NLS-1$
>-                            builder.append(getData().getId());
>-                            builder.append(getData().getName());
>+                            String threadId = getData().getId();
>+                            if (threadId != null) {
>+                            	builder.append(threadId);
>+                            }
>+                            String threadName = getData().getName();
>+                            if (threadName != null) {
>+                            	builder.append(threadName);
>+                            }
> 
>                             rm.setData(builder.toString());
>                             rm.done();

Flags:

marc.khouzam: iplog-

Actions: View | Diff

Attachments on bug 356463: 202603