Attachment 200541 Details for Bug 353341 – Patch to add IHeapObjectArgument to ThreadOverviewQuery

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to add IHeapObjectArgument to ThreadOverviewQuery

thread_overview_input.patch (text/plain), 2.30 KB, created by Kevin Grigorenko

on 2011-07-28 12:03:48 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Kevin Grigorenko

Created: 2011-07-28 12:03:48 EDT

Size: 2.30 KB

patch

obsolete

>Index: src/org/eclipse/mat/inspections/threads/ThreadOverviewQuery.java
>===================================================================
>--- src/org/eclipse/mat/inspections/threads/ThreadOverviewQuery.java	(revision 1164)
>+++ src/org/eclipse/mat/inspections/threads/ThreadOverviewQuery.java	(working copy)
>@@ -34,6 +34,7 @@
> import org.eclipse.mat.query.annotations.Icon;
> import org.eclipse.mat.snapshot.ISnapshot;
> import org.eclipse.mat.snapshot.model.IClass;
>+import org.eclipse.mat.snapshot.query.IHeapObjectArgument;
> import org.eclipse.mat.snapshot.query.Icons;
> import org.eclipse.mat.snapshot.query.SnapshotQuery;
> import org.eclipse.mat.util.IProgressListener;
>@@ -45,21 +46,38 @@
>     @Argument
>     public ISnapshot snapshot;
> 
>+    @Argument(isMandatory = false, flag = Argument.UNFLAGGED)
>+    public IHeapObjectArgument objects;
>+
>     public IResult execute(IProgressListener listener) throws Exception
>     {
>         listener.subTask(Messages.ThreadOverviewQuery_SearchingThreads);
> 
>         List<ThreadInfoImpl> result = new ArrayList<ThreadInfoImpl>();
> 
>-        Collection<IClass> classes = snapshot.getClassesByName("java.lang.Thread", true); //$NON-NLS-1$
>-        if (classes != null)
>-            for (IClass clasz : classes)
>+        for (int[] objectIds : objects)
>+        {
>+            for (int objectId : objectIds)
>             {
>-                for (int id : clasz.getObjectIds())
>+                result.add(ThreadInfoImpl.build(snapshot.getObject(objectId), false, listener));
>+            }
>+        }
>+
>+        // If no object specification was passed in, fall back
>+        if (result.size() == 0)
>+        {
>+            Collection<IClass> classes = snapshot.getClassesByName("java.lang.Thread", true); //$NON-NLS-1$
>+            if (classes != null)
>+            {
>+                for (IClass clasz : classes)
>                 {
>-                    result.add(ThreadInfoImpl.build(snapshot.getObject(id), false, listener));
>+                    for (int id : clasz.getObjectIds())
>+                    {
>+                        result.add(ThreadInfoImpl.build(snapshot.getObject(id), false, listener));
>+                    }
>                 }
>             }
>+        }
> 
>         Collections.sort(result, new Comparator<ThreadInfoImpl>()
>         {
>

Actions: View | Diff

Attachments on bug 353341: 200541 | 200542