Attachment 200166 Details for Bug 351527 – fix for 1.4.1

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix for 1.4.1

bug351527_sr141.patch (text/plain), 2.91 KB, created by Tim Buschtoens

on 2011-07-22 06:09:09 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Buschtoens

Created: 2011-07-22 06:09:09 EDT

Size: 2.91 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/rwt/widgets/MultiCellWidget.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/rwt/widgets/Attic/MultiCellWidget.js,v
>retrieving revision 1.25
>diff -u -r1.25 MultiCellWidget.js
>--- js/org/eclipse/rwt/widgets/MultiCellWidget.js	13 May 2011 13:17:13 -0000	1.25
>+++ js/org/eclipse/rwt/widgets/MultiCellWidget.js	22 Jul 2011 09:19:10 -0000
>@@ -42,7 +42,7 @@
>     this.initCursor();    
>     this.initTextColor();        
>   },
>-  
>+
>   destruct : function() {
>     this._disposeObjectDeep( "__cellData", 0 );
>     this._disposeObjectDeep( "__cellNodes", 0 );
>@@ -130,6 +130,7 @@
>   },
> 
>   members : {
>+
>     // TODO [tb] : clean up api (private/public, order)
> 
>     ///////////////////////
>@@ -187,10 +188,12 @@
>     },
>     
>     setCellWidth : function( cell, width ) {
>-      this._setCellWidth( cell, width );
>-      this._invalidateTotalSpacing(); 
>-      this._invalidatePreferredInnerWidth(); 
>-      this._scheduleLayoutX(); 
>+      if( this._getCellWidth( cell ) !== width ) {
>+        this._setCellWidth( cell, width );
>+        this._invalidateTotalSpacing(); 
>+        this._invalidatePreferredInnerWidth(); 
>+        this._scheduleLayoutX(); 
>+      }
>     },
>     
>     setCellHeight : function( cell, height ) {
>@@ -384,6 +387,10 @@
>       this.__cellData[ cell ][ 2 ] = width;
>     },
> 
>+    _getCellWidth : function( cell ) {
>+      return this.__cellData[ cell ][ 2 ];
>+    },
>+
>     _setCellHeight : function( cell, height ) {
>       this.__cellData[ cell ][ 3 ] = height;
>     },
>#P org.eclipse.rap.rwt.q07.jstest
>Index: js/org/eclipse/rwt/test/tests/MultiCellWidgetTest.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt.test/org.eclipse.rap.rwt.q07.jstest/js/org/eclipse/rwt/test/tests/MultiCellWidgetTest.js,v
>retrieving revision 1.8
>diff -u -r1.8 MultiCellWidgetTest.js
>--- js/org/eclipse/rwt/test/tests/MultiCellWidgetTest.js	14 Apr 2011 14:03:38 -0000	1.8
>+++ js/org/eclipse/rwt/test/tests/MultiCellWidgetTest.js	22 Jul 2011 09:19:11 -0000
>@@ -286,7 +286,18 @@
>       assertEquals( 0 , widget.getTotalSpacing() );
>       this.disposeWidget( widget );      
>     },
>-    
>+
>+    testSettingCellWidthTwice : function() {
>+      var widget = this.createDefaultWidget();
>+      this.initWidget( widget, true );
>+      widget.setCellWidth( 0, 10 );
>+      assertTrue( widget._isInGlobalJobQueue );
>+      this.testUtil.flush();
>+      widget.setCellWidth( 0, 10 );
>+      assertIdentical( undefined, widget._isInGlobalJobQueue );  
>+      this.disposeWidget( widget );      
>+    },
>+
>     testInvalidateFrameDimension : function() {
>       var widget = this.createDefaultWidget();
>       widget.setPadding( 0, 0, 0, 0 );

Actions: View | Diff

Attachments on bug 351527: 200166