Attachment 200152 Details for Bug 351849 – Proposed patch for v14_Maintenance branch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch for v14_Maintenance branch

Bug-351849-v1.4.patch (text/plain), 2.34 KB, created by Ivan Furnadjiev

on 2011-07-22 03:47:18 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2011-07-22 03:47:18 EDT

Size: 2.34 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Table.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Attic/Table.js,v
>retrieving revision 1.92.2.1
>diff -u -r1.92.2.1 Table.js
>--- js/org/eclipse/swt/widgets/Table.js	19 May 2011 08:15:03 -0000	1.92.2.1
>+++ js/org/eclipse/swt/widgets/Table.js	22 Jul 2011 07:33:30 -0000
>@@ -1755,21 +1755,23 @@
>         var pageX = evt.getPageX();
>         var pageY = evt.getPageY();
>         var row = this._getRowAtPoint( pageX, pageY );
>-        var itemIndex = row.getItemIndex();
>-        if( itemIndex != -1 ) {
>-	        var widgetManager = org.eclipse.swt.WidgetManager.getInstance();
>-	        var itemId = widgetManager.findIdByWidget( this._items[ itemIndex ] );
>-	        var columns = this.getColumns();
>-	        var columnIndex = columns.length == 0 ? 0 : -1;
>-	        var element = this._clientArea.getElement();
>-	        var leftOffset = qx.bom.element.Location.getLeft( element );
>-	        for( var i = 0; columnIndex == -1 && i < columns.length; i++ ) {
>-	          var pageLeft = leftOffset + this._itemLeft[ i ];
>-	          if( pageX >= pageLeft && pageX < pageLeft + this._itemWidth[ i ] ) {
>-	            columnIndex = i;
>-	          }
>-	        }        
>-	        this._cellToolTip.setCell( itemId, columnIndex );
>+        if( row != null ) {
>+          var itemIndex = row.getItemIndex();
>+          if( itemIndex != -1 ) {
>+            var widgetManager = org.eclipse.swt.WidgetManager.getInstance();
>+            var itemId = widgetManager.findIdByWidget( this._items[ itemIndex ] );
>+            var columns = this.getColumns();
>+            var columnIndex = columns.length == 0 ? 0 : -1;
>+            var element = this._clientArea.getElement();
>+            var leftOffset = qx.bom.element.Location.getLeft( element );
>+            for( var i = 0; columnIndex == -1 && i < columns.length; i++ ) {
>+              var pageLeft = leftOffset + this._itemLeft[ i ];
>+              if( pageX >= pageLeft && pageX < pageLeft + this._itemWidth[ i ] ) {
>+                columnIndex = i;
>+              }
>+            }
>+            this._cellToolTip.setCell( itemId, columnIndex );
>+          }
>         }
>       }
>     },

Flags:

ivan: review?
rsternberg: review+

Actions: View | Diff

Attachments on bug 351849: 199500 | 200152