Attachment 199854 Details for Bug 352193 – patch for cocoa

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch for cocoa

cocoa.patch (text/plain), 1.83 KB, created by Philippe Marschall

on 2011-07-18 14:15:39 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Philippe Marschall

Created: 2011-07-18 14:15:39 EDT

Size: 1.83 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.swt
>Index: Eclipse SWT/cocoa/org/eclipse/swt/widgets/Table.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Table.java,v
>retrieving revision 1.211
>diff -u -r1.211 Table.java
>--- Eclipse SWT/cocoa/org/eclipse/swt/widgets/Table.java	17 May 2011 14:47:43 -0000	1.211
>+++ Eclipse SWT/cocoa/org/eclipse/swt/widgets/Table.java	18 Jul 2011 18:14:05 -0000
>@@ -3245,16 +3245,23 @@
> 	return widget.isRowSelected(rowIndex);
> }
> 
>-void tableView_setObjectValue_forTableColumn_row (int /*long*/ id, int /*long*/ sel, int /*long*/ aTableView, int /*long*/ anObject, int /*long*/ aTableColumn, int /*long*/ rowIndex) {
>+void tableView_setObjectValue_forTableColumn_row (long /*int*/ id, long /*int*/ sel, long /*int*/ aTableView, long /*int*/ anObject, long /*int*/ aTableColumn, long /*int*/ rowIndex) {
> 	if (checkColumn != null && aTableColumn == checkColumn.id)  {
>-		TableItem item = items [(int)/*64*/rowIndex];
>-		item.checked = !item.checked;
>-		Event event = new Event ();
>-		event.detail = SWT.CHECK;
>-		event.item = item;
>-		event.index = (int)/*64*/rowIndex;
>-		sendSelectionEvent (SWT.Selection, event, false);
>-		item.redraw (-1);
>+		NSTableView widget = (NSTableView)view;
>+		NSIndexSet selection = widget.selectedRowIndexes();
>+		int count = (int)/*64*/selection.count();
>+		int /*long*/ [] indices = new int /*long*/ [count];
>+		selection.getIndexes(indices, count, 0);
>+		for (int i = 0; i < indices.length; i++) {
>+			TableItem item = items [(int)/*64*/indices [i]];
>+			item.checked = !item.checked;
>+			Event event = new Event ();
>+			event.detail = SWT.CHECK;
>+			event.item = item;
>+			event.index = (int)/*64*/rowIndex;
>+			sendSelectionEvent (SWT.Selection, event, false);
>+			item.redraw (-1);
>+		}
> 	}
> }
>

Actions: View | Diff

Attachments on bug 352193: 199735 | 199810 | 199854