Attachment 199816 Details for Bug 352305 – Proposed patch for v1.4_Maintenance

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch for v1.4_Maintenance

Bug-352305.patch (text/plain), 1.62 KB, created by Ivan Furnadjiev

on 2011-07-18 05:21:48 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2011-07-18 05:21:48 EDT

Size: 1.62 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: src/org/eclipse/swt/internal/widgets/displaykit/DisplayLCA.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/src/org/eclipse/swt/internal/widgets/displaykit/Attic/DisplayLCA.java,v
>retrieving revision 1.46
>diff -u -r1.46 DisplayLCA.java
>--- src/org/eclipse/swt/internal/widgets/displaykit/DisplayLCA.java	25 Apr 2011 11:32:37 -0000	1.46
>+++ src/org/eclipse/swt/internal/widgets/displaykit/DisplayLCA.java	18 Jul 2011 09:18:57 -0000
>@@ -23,6 +23,7 @@
> import org.eclipse.rwt.internal.lifecycle.*;
> import org.eclipse.rwt.internal.service.*;
> import org.eclipse.rwt.internal.theme.*;
>+import org.eclipse.rwt.internal.util.EncodingUtil;
> import org.eclipse.rwt.internal.util.NumberFormatUtil;
> import org.eclipse.rwt.lifecycle.*;
> import org.eclipse.swt.dnd.DragSource;
>@@ -239,9 +240,10 @@
>                        ? oldExitConfirmation != null
>                        : !exitConfirmation.equals( oldExitConfirmation );
>     if( hasChanged ) {
>-      String exitConfirmationStr = exitConfirmation == null
>-                                   ? "null"
>-                                   : "\"" + exitConfirmation + "\"";
>+      String exitConfirmationStr = "null";
>+      if( exitConfirmation != null ) {
>+        exitConfirmationStr = "\"" + EncodingUtil.escapeDoubleQuoted( exitConfirmation ) + "\"";
>+      }
>       String code = "qx.core.Init.getInstance().getApplication()"
>                     + ".setExitConfirmation( "
>                     + exitConfirmationStr

Flags:

ivan: review?

Actions: View | Diff

Attachments on bug 352305: 199816