Attachment 199605 Details for Bug 351997 – patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch

patchFor351997.patch (text/plain), 1.93 KB, created by Chris Jaun

on 2011-07-13 11:51:52 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Jaun

Created: 2011-07-13 11:51:52 EDT

Size: 1.93 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.wst.jsdt.core
>Index: src/org/eclipse/wst/jsdt/core/Signature.java
>===================================================================
>RCS file: /cvsroot/webtools/org.eclipse.jsdt/plugins/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/core/Signature.java,v
>retrieving revision 1.14.2.4
>diff -u -r1.14.2.4 Signature.java
>--- src/org/eclipse/wst/jsdt/core/Signature.java	1 Jul 2011 22:12:20 -0000	1.14.2.4
>+++ src/org/eclipse/wst/jsdt/core/Signature.java	13 Jul 2011 15:50:05 -0000
>@@ -292,13 +292,12 @@
>  *  
>  */
> public static char[] createCharArrayTypeSignature(char[] typeName, boolean isResolved) {
>-	if (typeName == null)
>+	if (typeName == null || typeName.length == 0)
> 	{
> 		return new char[]{C_ANY};
> 	}
> 
> 	int length = typeName.length;
>-	if (length == 0) throw new IllegalArgumentException(new String(typeName));
> 	StringBuffer buffer = new StringBuffer(5);
> 	int pos = encodeTypeSignature(typeName, 0, isResolved, length, buffer);
> 	pos = consumeWhitespace(typeName, pos, length);
>Index: src/org/eclipse/wst/jsdt/internal/compiler/util/Util.java
>===================================================================
>RCS file: /cvsroot/webtools/org.eclipse.jsdt/plugins/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/compiler/util/Util.java,v
>retrieving revision 1.11.2.3
>diff -u -r1.11.2.3 Util.java
>--- src/org/eclipse/wst/jsdt/internal/compiler/util/Util.java	1 Jul 2011 22:20:31 -0000	1.11.2.3
>+++ src/org/eclipse/wst/jsdt/internal/compiler/util/Util.java	13 Jul 2011 15:50:05 -0000
>@@ -547,7 +547,7 @@
> 						selector = ((ILiteral) arrayRef.position).source();
> 					}
> 					else {
>-						selector = CharOperation.concatWith(new char[][]{((ILiteral) arrayRef.position).source(), selector}, ',');
>+						selector = CharOperation.concatWith(new char[][]{((ILiteral) arrayRef.position).source(), selector}, '.');
> 					}
> 					currExpr = arrayRef.receiver;
> 				}

Actions: View | Diff

Attachments on bug 351997: 199605