Attachment 199323 Details for Bug 351073 – patch for "terminate previous launch"

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch for "terminate previous launch"

351073_v1.patch (text/plain), 9.01 KB, created by Beyhan Veliev

on 2011-07-08 07:29:36 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Beyhan Veliev

Created: 2011-07-08 07:29:36 EDT

Size: 9.01 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.ui.launch
>Index: src/org/eclipse/rap/ui/internal/launch/LaunchMessages.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/tooling/org.eclipse.rap.ui.launch/src/org/eclipse/rap/ui/internal/launch/LaunchMessages.java,v
>retrieving revision 1.11
>diff -u -r1.11 LaunchMessages.java
>--- src/org/eclipse/rap/ui/internal/launch/LaunchMessages.java	28 Apr 2011 16:09:49 -0000	1.11
>+++ src/org/eclipse/rap/ui/internal/launch/LaunchMessages.java	8 Jul 2011 11:25:53 -0000
>@@ -77,7 +77,6 @@
>   public static String MainTab_RuntimeSettings;
>   public static String MainTab_ServletAndEntryPoint;
>   public static String MainTab_ServletName;
>-  public static String MainTab_TerminatePrevious;
>   public static String ServletNameSelectionDialog_Message;
>   public static String ServletNameSelectionDialog_Searching;
>   public static String ServletNameSelectionDialog_Title;
>Index: src/org/eclipse/rap/ui/internal/launch/RAPLaunchConfig.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/tooling/org.eclipse.rap.ui.launch/src/org/eclipse/rap/ui/internal/launch/RAPLaunchConfig.java,v
>retrieving revision 1.12
>diff -u -r1.12 RAPLaunchConfig.java
>--- src/org/eclipse/rap/ui/internal/launch/RAPLaunchConfig.java	28 Apr 2011 16:09:49 -0000	1.12
>+++ src/org/eclipse/rap/ui/internal/launch/RAPLaunchConfig.java	8 Jul 2011 11:25:55 -0000
>@@ -129,8 +129,6 @@
>     = PREFIX + "servletName"; //$NON-NLS-1$
>   public static final String ENTRY_POINT
>     = PREFIX + "entryPoint"; //$NON-NLS-1$
>-  public static final String TERMINATE_PREVIOUS
>-    = PREFIX + "terminatePrevious"; //$NON-NLS-1$
>   public static final String OPEN_BROWSER
>     = PREFIX + "openBrowser"; //$NON-NLS-1$
>   public static final String BROWSER_MODE
>@@ -159,7 +157,6 @@
>   // Default values for launch configuration attribute names
>   private static final String DEFAULT_SERVLET_NAME = "rap"; //$NON-NLS-1$
>   private static final String DEFAULT_ENTRY_POINT = ""; //$NON-NLS-1$
>-  private static final boolean DEFAULT_TERMINATE_PREVIOUS = true;
>   private static final BrowserMode DEFAULT_BROWSER_MODE = BrowserMode.INTERNAL;
>   private static final int DEFAULT_PORT = 10080;
>   private static final boolean DEFAULT_USE_MANUAL_PORT = false;
>@@ -176,7 +173,6 @@
>   public static void setDefaults( ILaunchConfigurationWorkingCopy config ) {
>     config.setAttribute( SERVLET_NAME, DEFAULT_SERVLET_NAME );
>     config.setAttribute( ENTRY_POINT, DEFAULT_ENTRY_POINT );
>-    config.setAttribute( TERMINATE_PREVIOUS, DEFAULT_TERMINATE_PREVIOUS );
>     config.setAttribute( BROWSER_MODE, DEFAULT_BROWSER_MODE.getName() );
>     config.setAttribute( PORT, DEFAULT_PORT );
>     config.setAttribute( USE_MANUAL_PORT, DEFAULT_USE_MANUAL_PORT );
>@@ -287,16 +283,6 @@
>     workingCopy.setAttribute( ENTRY_POINT, entryPoint );
>   }
> 
>-  public boolean getTerminatePrevious() throws CoreException {
>-    return config.getAttribute( TERMINATE_PREVIOUS,
>-                                DEFAULT_TERMINATE_PREVIOUS );
>-  }
>-
>-  public void setTerminatePrevious( final boolean terminatePrevious ) {
>-    checkWorkingCopy();
>-    workingCopy.setAttribute( TERMINATE_PREVIOUS, terminatePrevious );
>-  }
>-
>   public boolean getOpenBrowser() throws CoreException {
>     return config.getAttribute( OPEN_BROWSER, true );
>   }
>Index: src/org/eclipse/rap/ui/internal/launch/RAPLaunchDelegate.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/tooling/org.eclipse.rap.ui.launch/src/org/eclipse/rap/ui/internal/launch/RAPLaunchDelegate.java,v
>retrieving revision 1.32
>diff -u -r1.32 RAPLaunchDelegate.java
>--- src/org/eclipse/rap/ui/internal/launch/RAPLaunchDelegate.java	29 Apr 2011 14:45:23 -0000	1.32
>+++ src/org/eclipse/rap/ui/internal/launch/RAPLaunchDelegate.java	8 Jul 2011 11:25:56 -0000
>@@ -282,17 +282,15 @@
>   private void terminateIfRunning( final IProgressMonitor monitor ) 
>     throws CoreException 
>   {
>-    if( config.getTerminatePrevious() ) {
>-      String taskName = LaunchMessages.RAPLaunchDelegate_TerminatePreviousTaskName;
>-      monitor.beginTask( taskName, IProgressMonitor.UNKNOWN );
>-      try {
>-        final ILaunch runningLaunch = findRunning();
>-        if( runningLaunch != null ) {
>-          terminate( runningLaunch );
>-        }
>-      } finally {
>-        monitor.done();
>+    String taskName = LaunchMessages.RAPLaunchDelegate_TerminatePreviousTaskName;
>+    monitor.beginTask( taskName, IProgressMonitor.UNKNOWN );
>+    try {
>+      final ILaunch runningLaunch = findRunning();
>+      if( runningLaunch != null ) {
>+        terminate( runningLaunch );
>       }
>+    } finally {
>+      monitor.done();
>     }
>   }
> 
>Index: src/org/eclipse/rap/ui/internal/launch/messages.properties
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/tooling/org.eclipse.rap.ui.launch/src/org/eclipse/rap/ui/internal/launch/messages.properties,v
>retrieving revision 1.15
>diff -u -r1.15 messages.properties
>--- src/org/eclipse/rap/ui/internal/launch/messages.properties	4 Jul 2011 11:31:47 -0000	1.15
>+++ src/org/eclipse/rap/ui/internal/launch/messages.properties	8 Jul 2011 11:25:56 -0000
>@@ -83,4 +83,3 @@
> MainTab_RuntimeSettings=Runtime Settings
> MainTab_ServletAndEntryPoint=Servlet and Entry Point to Run
> MainTab_ServletName=&Servlet Name
>-MainTab_TerminatePrevious=Terminate possibly running previous launch
>Index: src/org/eclipse/rap/ui/internal/launch/tab/MainTab.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/tooling/org.eclipse.rap.ui.launch/src/org/eclipse/rap/ui/internal/launch/tab/MainTab.java,v
>retrieving revision 1.24
>diff -u -r1.24 MainTab.java
>--- src/org/eclipse/rap/ui/internal/launch/tab/MainTab.java	29 Apr 2011 14:45:23 -0000	1.24
>+++ src/org/eclipse/rap/ui/internal/launch/tab/MainTab.java	8 Jul 2011 11:25:57 -0000
>@@ -51,7 +51,6 @@
>   private final Image warnImage;
>   private Text servletNameTextField;
>   private Text entryPointTextField;
>-  private Button terminatePreviousCheckBox;
>   private Button openBrowserCheckBox;
>   private Button internalBrowserRadioButton;
>   private Button externalBrowserRadioButton;
>@@ -130,7 +129,6 @@
>     try {
>       servletNameTextField.setText( rapConfig.getServletName() );
>       entryPointTextField.setText( rapConfig.getEntryPoint() );
>-      terminatePreviousCheckBox.setSelection( rapConfig.getTerminatePrevious() );
>       manualPortCheckBox.setSelection( rapConfig.getUseManualPort() );
>       portSpinner.setSelection( rapConfig.getPort() );
>       contextPathCheckBox.setSelection( rapConfig.getUseManualContextPath() );
>@@ -164,7 +162,6 @@
>     RAPLaunchConfig rapConfig = new RAPLaunchConfig( config );
>     rapConfig.setServletName( servletNameTextField.getText() );
>     rapConfig.setEntryPoint( entryPointTextField.getText() );
>-    rapConfig.setTerminatePrevious( terminatePreviousCheckBox.getSelection() );
>     rapConfig.setOpenBrowser( openBrowserCheckBox.getSelection() );
>     rapConfig.setBrowserMode( getBrowserMode() );
>     portSpinner.setEnabled( manualPortCheckBox.getSelection() );
>@@ -240,7 +237,6 @@
>     group.setText( LaunchMessages.MainTab_ServletAndEntryPoint );
>     createServletNamePart( group );
>     createEntryPointPart( group );
>-    createSessionPart( group );
>   }
> 
>   private void createServletNamePart( Composite parent ) {
>@@ -273,14 +269,6 @@
>     } );
>   }
> 
>-  private void createSessionPart( Composite parent ) {
>-    terminatePreviousCheckBox = new Button( parent, SWT.CHECK );
>-    terminatePreviousCheckBox.setLayoutData( spanHorizontal( 3, 0 ) );
>-    String text = LaunchMessages.MainTab_TerminatePrevious;
>-    terminatePreviousCheckBox.setText( text );
>-    terminatePreviousCheckBox.addSelectionListener( selectionListener );
>-  }
>-  
>   private void createBrowserModeSection( Composite parent ) {
>     Group group = new Group( parent, SWT.NONE );
>     group.setLayoutData( fillHorizontal.create() );
>#P org.eclipse.rap.ui.tests
>Index: src/org/eclipse/rap/ui/internal/launch/RAPLaunchConfig_Test.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/tooling/org.eclipse.rap.ui.tests/src/org/eclipse/rap/ui/internal/launch/RAPLaunchConfig_Test.java,v
>retrieving revision 1.5
>diff -u -r1.5 RAPLaunchConfig_Test.java
>--- src/org/eclipse/rap/ui/internal/launch/RAPLaunchConfig_Test.java	28 Apr 2011 16:09:47 -0000	1.5
>+++ src/org/eclipse/rap/ui/internal/launch/RAPLaunchConfig_Test.java	8 Jul 2011 11:26:00 -0000
>@@ -37,7 +37,6 @@
>   
>   public void testInitialValues() throws CoreException {
>     assertFalse( rapConfig.getUseManualPort() );
>-    assertTrue( rapConfig.getTerminatePrevious() );
>     assertFalse( "".equals( rapConfig.getServletName() ) );
>     assertTrue( "".equals( rapConfig.getEntryPoint() ) );
>     assertEquals( Level.OFF, rapConfig.getLogLevel() );

Actions: View | Diff

Attachments on bug 351073: 199323 | 199338