Attachment 198771 Details for Bug 349771 – patch V2

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch V2

patch349771V2.txt (text/plain), 2.09 KB, created by Frank Becker

on 2011-06-28 15:37:56 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frank Becker

Created: 2011-06-28 15:37:56 EDT

Size: 2.09 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.bugzilla.ui
>Index: src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditorPage.java
>===================================================================
>RCS file: /cvsroot/mylyn/org.eclipse.mylyn.tasks/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditorPage.java,v
>retrieving revision 1.63
>diff -u -r1.63 BugzillaTaskEditorPage.java
>--- src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditorPage.java	20 Jun 2011 19:28:59 -0000	1.63
>+++ src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditorPage.java	28 Jun 2011 19:36:28 -0000
>@@ -98,6 +98,7 @@
> 	protected Set<TaskEditorPartDescriptor> createPartDescriptors() {
> 		Set<TaskEditorPartDescriptor> descriptors = super.createPartDescriptors();
> 		boolean hasPartComments = false;
>+		boolean hasPartNewComment = false;
> 		// remove unnecessary default editor parts
> 		for (TaskEditorPartDescriptor taskEditorPartDescriptor : descriptors) {
> 			if (taskEditorPartDescriptor.getId().equals(ID_PART_PEOPLE)) {
>@@ -115,7 +116,7 @@
> 		for (TaskEditorPartDescriptor taskEditorPartDescriptor : descriptors) {
> 			if (taskEditorPartDescriptor.getId().equals(ID_PART_NEW_COMMENT)) {
> 				descriptors.remove(taskEditorPartDescriptor);
>-				hasPartComments = true;
>+				hasPartNewComment = true;
> 				break;
> 			}
> 		}
>@@ -162,14 +163,15 @@
> 			// ignore
> 		}
> 
>-		// Add the updated Bugzilla new comment part
>-		descriptors.add(new TaskEditorPartDescriptor(ID_PART_NEW_COMMENT) {
>-			@Override
>-			public AbstractTaskEditorPart createPart() {
>-				return new BugzillaTaskEditorNewCommentPart();
>-			}
>-		}.setPath(PATH_COMMENTS));
>-
>+		if (hasPartNewComment) {
>+			// Add the updated Bugzilla new comment part
>+			descriptors.add(new TaskEditorPartDescriptor(ID_PART_NEW_COMMENT) {
>+				@Override
>+				public AbstractTaskEditorPart createPart() {
>+					return new BugzillaTaskEditorNewCommentPart();
>+				}
>+			}.setPath(PATH_COMMENTS));
>+		}
> 		// Add the updated Bugzilla people part
> 		descriptors.add(new TaskEditorPartDescriptor(ID_PART_PEOPLE) {
> 			@Override

Actions: View | Diff

Attachments on bug 349771: 198759 | 198760 | 198771 | 198772 | 198942 | 198943 | 200529 | 200530 | 203832 | 204470