Attachment 198564 Details for Bug 350314 – Patch to render committer image

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to render committer image

clientpatch.txt (text/plain), 3.07 KB, created by John Arthorne

on 2011-06-24 14:15:24 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: John Arthorne

Created: 2011-06-24 14:15:24 EDT

Size: 3.07 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.client.git/web/orion/git/git-commit-details.js b/bundles/org.eclipse.orion.client.git/web/orion/git/git-commit-details.js
>index da1644b..4827b7e 100644
>--- a/bundles/org.eclipse.orion.client.git/web/orion/git/git-commit-details.js
>+++ b/bundles/org.eclipse.orion.client.git/web/orion/git/git-commit-details.js
>@@ -80,7 +80,7 @@ exports.CommitDetails = (function() {
> 			dojo.place("<span id='commitMetaCommands' class='paneHeadingToolbar'></span>", commandCol, "only");
> 			
> 			if (commitDetails != null){
>-				
>+
> 				// commit details
> 				var tr, col1, col2;
> 				var tbody = dojo.create("tbody", null, commitMetaTable);
>@@ -91,9 +91,15 @@ exports.CommitDetails = (function() {
> 				var col2 = dojo.create("td", null, tr, "last");
> 				dojo.place(document.createTextNode(commitDetails.AuthorName + " (" + commitDetails.AuthorEmail + ")"), col2, "only");
> 				dojo.place(tr, tbody, "last");
>-				var col3 = dojo.create("td", {id: tr.id+"actions"}, tr, "last");
>+				var col3 = dojo.create("td", {id: tr.id+"actions", rowspan:"4"}, tr, "last");
> 				dojo.style(col3, "whiteSpace", "nowrap");
> 				dojo.style(col3, "textAlign", "right");
>+				if (commitDetails.AuthorImage) {
>+					var image = new Image();
>+					image.src=commitDetails.AuthorImage;
>+					image.name=commitDetails.AuthorName;
>+					dojo.place(image, col3, "last");
>+				}
> 				
> 				tr = dojo.create("tr");
> 				col1 = dojo.create("td", {style: "padding-left: 5px; padding-right: 5px"}, tr, "last");
>@@ -101,9 +107,6 @@ exports.CommitDetails = (function() {
> 				col2 = dojo.create("td", null, tr, "last");
> 				dojo.place(document.createTextNode(commitDetails.CommitterName + " (" + commitDetails.CommitterEmail + ")"), col2, "only");
> 				dojo.place(tr, tbody, "last");
>-				col3 = dojo.create("td", {id: tr.id+"actions"}, tr, "last");
>-				dojo.style(col3, "whiteSpace", "nowrap");
>-				dojo.style(col3, "textAlign", "right");
> 				
> 				tr = dojo.create("tr");
> 				col1 = dojo.create("td", {style: "padding-left: 5px; padding-right: 5px"}, tr, "last");
>@@ -111,9 +114,6 @@ exports.CommitDetails = (function() {
> 				col2 = dojo.create("td", null, tr, "last");
> 				dojo.place(document.createTextNode(commitDetails.Message), col2, "only");
> 				dojo.place(tr, tbody, "last");
>-				col3 = dojo.create("td", {id: tr.id+"actions"}, tr, "last");
>-				dojo.style(col3, "whiteSpace", "nowrap");
>-				dojo.style(col3, "textAlign", "right");
> 				
> 				tr = dojo.create("tr");
> 				col1 = dojo.create("td", {style: "padding-left: 5px; padding-right: 5px"}, tr, "last");
>@@ -121,9 +121,6 @@ exports.CommitDetails = (function() {
> 				col2 = dojo.create("td", null, tr, "last");
> 				dojo.place(document.createTextNode(commitDetails.Name), col2, "only");
> 				dojo.place(tr, tbody, "last");
>-				col3 = dojo.create("td", {id: tr.id+"actions"}, tr, "last");
>-				dojo.style(col3, "whiteSpace", "nowrap");
>-				dojo.style(col3, "textAlign", "right");
> 			
> //			var actionsWrapper = dojo.create("span", {id: tr.id+"actionsWrapper"}, col3, "only");
> //			// we must hide/show the span rather than the column.  IE and Chrome will not consider

Actions: View | Diff

Attachments on bug 350314: 198563 | 198564