Attachment 198354 Details for Bug 335857 – an incomplete, buggy fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] an incomplete, buggy fix

patch.txt (text/plain), 1.30 KB, created by Mohamed El-Kholy

on 2011-06-21 14:12:51 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mohamed El-Kholy

Created: 2011-06-21 14:12:51 EDT

Size: 1.30 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.swt
>Index: Eclipse SWT/win32/org/eclipse/swt/widgets/Sash.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Sash.java,v
>retrieving revision 1.49
>diff -u -r1.49 Sash.java
>--- Eclipse SWT/win32/org/eclipse/swt/widgets/Sash.java	16 May 2011 17:30:14 -0000	1.49
>+++ Eclipse SWT/win32/org/eclipse/swt/widgets/Sash.java	21 Jun 2011 18:06:28 -0000
>@@ -207,6 +207,9 @@
> 			POINT pt = new POINT ();
> 			if ((style & SWT.VERTICAL) != 0) {
> 				if (wParam == OS.VK_UP || wParam == OS.VK_DOWN) break;
>+				if(this.isParentrtl()) {
>+					step=-step;
>+				}
> 				pt.x = wParam == OS.VK_LEFT ? -step : step;
> 			} else {
> 				if (wParam == OS.VK_LEFT || wParam == OS.VK_RIGHT) break;
>@@ -244,6 +247,9 @@
> 			Event event = new Event ();
> 			event.x = newX;
> 			event.y = newY;
>+			//fix trial
>+			event.x = pt.x;
>+			//end of fix trial
> 			event.width = width;
> 			event.height = height;
> 			sendSelectionEvent  (SWT.Selection, event, true);
>@@ -417,4 +423,12 @@
> 	return result;
> }
> 
>+//tmp fix start
>+public boolean isParentrtl() {
>+	int parentStyle=getParent().getStyle();
>+
>+	return ((parentStyle&SWT.RIGHT_TO_LEFT)!=0);
>+
>+}
>+//tmp fix end
> }

Actions: View | Diff

Attachments on bug 335857: 198354