Attachment 198203 Details for Bug 349713 – Fix v01

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix v01

patch.txt (text/plain), 1.37 KB, created by John Arthorne

on 2011-06-17 14:11:38 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: John Arthorne

Created: 2011-06-17 14:11:38 EDT

Size: 1.37 KB

patch

obsolete

>diff --git a/bundles/org.eclipse.orion.server.user.securestorage/src/org/eclipse/orion/internal/server/user/securestorage/SecureStorageCredentialsService.java b/bundles/org.eclipse.orion.server.user.securestorage/src/org/eclipse/orion/internal/server/user/securestorage/SecureStorageCredentialsService.java
>index 971b33f..239651f 100644
>--- a/bundles/org.eclipse.orion.server.user.securestorage/src/org/eclipse/orion/internal/server/user/securestorage/SecureStorageCredentialsService.java
>+++ b/bundles/org.eclipse.orion.server.user.securestorage/src/org/eclipse/orion/internal/server/user/securestorage/SecureStorageCredentialsService.java
>@@ -196,10 +196,13 @@ public class SecureStorageCredentialsService implements IOrionCredentialsService
> 	}
> 	
> 	private ISecurePreferences findNodeIgnoreCase(ISecurePreferences storage, String login){
>+		if (login == null)
>+			return null;
> 		ISecurePreferences usersPref = storage.node(USERS);
>-		for (int i=0 ; i<usersPref.childrenNames().length; i++){
>-			 if (login.equalsIgnoreCase(usersPref.node(usersPref.childrenNames()[i]).name()))
>-				 return usersPref.node(usersPref.childrenNames()[i]);
>+		String[] childrenNames = usersPref.childrenNames();
>+		for (int i=0 ; i<childrenNames.length; i++){
>+			 if (login.equalsIgnoreCase(usersPref.node(childrenNames[i]).name()))
>+				 return usersPref.node(childrenNames[i]);
> 		}
> 		return null;
> 	}

Actions: View | Diff

Attachments on bug 349713: 198203