Attachment 19760 Details for Bug 91004 – Patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch

patch_91004.txt (text/plain), 1.74 KB, created by Chris Gross

on 2005-04-11 11:43:27 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Gross

Created: 2005-04-11 11:43:27 EDT

Size: 1.74 KB

patch

obsolete

>Index: src/org/eclipse/jface/dialogs/TitleAreaDialog.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jface/src/org/eclipse/jface/dialogs/TitleAreaDialog.java,v
>retrieving revision 1.21
>diff -u -r1.21 TitleAreaDialog.java
>--- src/org/eclipse/jface/dialogs/TitleAreaDialog.java	25 Feb 2005 20:39:52 -0000	1.21
>+++ src/org/eclipse/jface/dialogs/TitleAreaDialog.java	11 Apr 2005 15:41:17 -0000
>@@ -269,7 +269,11 @@
>     private void determineTitleImageLargest() {
>         int titleY = titleImage.computeSize(SWT.DEFAULT, SWT.DEFAULT).y;
>         int labelY = titleLabel.computeSize(SWT.DEFAULT, SWT.DEFAULT).y;
>-        labelY += messageLabel.computeSize(SWT.DEFAULT, SWT.DEFAULT).y;
>+		//CGross (schtoo@schtoo.com)
>+		//Passing the messageLabel's size into the compute size method
>+		//so we can correctly determine message's height if it becomes
>+		//wrapped
>+        labelY += messageLabel.computeSize(messageLabel.getSize().x, SWT.DEFAULT).y;
>         FontData[] data = messageLabel.getFont().getFontData();
>         labelY += data[0].getHeight();
>         titleImageLargest = titleY > labelY;
>@@ -513,6 +517,16 @@
>             }
>         }
>         showMessage(newMessage, newImage);
>+		
>+		//CGross (schtoo@schtoo.com)
>+		//New message text requires this method to be re-executed
>+        determineTitleImageLargest();
>+
>+		//now recalculate layout positioning based on new titleImageLargest
>+		//value.
>+		int verticalSpacing = convertVerticalDLUsToPixels(IDialogConstants.VERTICAL_SPACING);
>+        int horizontalSpacing = convertHorizontalDLUsToPixels(IDialogConstants.HORIZONTAL_SPACING);
>+        setLayoutsForNormalMessage(verticalSpacing,horizontalSpacing);
>     }
> 
>     /**

Actions: View | Diff

Attachments on bug 91004: 19760