Attachment 197296 Details for Bug 347573 – Proposed fix for Graphics_Test#testGetImageWithClassLoader

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed fix for Graphics_Test#testGetImageWithClassLoader

clipboard.txt (text/plain), 1.66 KB, created by Rüdiger Herrmann

on 2011-06-03 05:40:10 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rüdiger Herrmann

Created: 2011-06-03 05:40:10 EDT

Size: 1.66 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt
>Index: src/org/eclipse/swt/internal/graphics/ImageFactory.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt/src/org/eclipse/swt/internal/graphics/ImageFactory.java,v
>retrieving revision 1.9
>diff -u -r1.9 ImageFactory.java
>--- src/org/eclipse/swt/internal/graphics/ImageFactory.java	2 Jun 2011 20:48:56 -0000	1.9
>+++ src/org/eclipse/swt/internal/graphics/ImageFactory.java	3 Jun 2011 09:38:10 -0000
>@@ -11,6 +11,7 @@
>  ******************************************************************************/
> package org.eclipse.swt.internal.graphics;
> 
>+import java.io.IOException;
> import java.io.InputStream;
> 
> import org.eclipse.rwt.RWT;
>@@ -18,6 +19,8 @@
> import org.eclipse.rwt.internal.util.*;
> import org.eclipse.rwt.internal.util.SharedInstanceBuffer.IInstanceCreator;
> import org.eclipse.rwt.resources.IResourceManager;
>+import org.eclipse.swt.SWT;
>+import org.eclipse.swt.SWTException;
> import org.eclipse.swt.graphics.Device;
> import org.eclipse.swt.graphics.Image;
> 
>@@ -67,7 +70,13 @@
> 
>   private Image createImage( String path, ClassLoader imageLoader ) {
>     InputStream inputStream = getInputStream( path, imageLoader );
>-    return createImage( null, path, inputStream );
>+    Image result = createImage( null, path, inputStream );
>+    try {
>+      inputStream.close();
>+    } catch( IOException ioe ) {
>+      throw new SWTException( SWT.ERROR_IO, ioe.getMessage() );
>+    }
>+    return result;
>   }
> 
>   private static Image createImageInstance( Device device, InternalImage internalImage ) {

Actions: View | Diff

Attachments on bug 347573: 197296