Attachment 196930 Details for Bug 345847 – fix for comment font

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix for comment font

clipboard.txt (text/plain), 2.09 KB, created by Steffen Pingel

on 2011-05-30 17:56:09 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Steffen Pingel

Created: 2011-05-30 17:56:09 EDT

Size: 2.09 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.tasks.ui
>Index: src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorCommentPart.java
>===================================================================
>RCS file: /cvsroot/mylyn/org.eclipse.mylyn.tasks/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorCommentPart.java,v
>retrieving revision 1.71
>diff -u -r1.71 TaskEditorCommentPart.java
>--- src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorCommentPart.java	30 May 2011 03:56:00 -0000	1.71
>+++ src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorCommentPart.java	30 May 2011 21:55:41 -0000
>@@ -54,7 +54,6 @@
> import org.eclipse.swt.widgets.Canvas;
> import org.eclipse.swt.widgets.Composite;
> import org.eclipse.swt.widgets.Control;
>-import org.eclipse.swt.widgets.Display;
> import org.eclipse.swt.widgets.Menu;
> import org.eclipse.ui.actions.ActionContext;
> import org.eclipse.ui.forms.IFormColors;
>@@ -423,17 +422,19 @@
> //				String value = commentID.getValue();
> //				sb.append(" (ID " + value + ")");
> //			}
>-			if (taskComment.getIsPrivate() != null) {
>-				if (taskComment.getIsPrivate()) {
>-					if (privateFont == null) {
>-						Font a = formHyperlink.getFont();
>-						FontData[] fd = a.getFontData();
>-						fd[0].setStyle(SWT.ITALIC | SWT.BOLD);
>-						privateFont = new Font(Display.getCurrent(), fd[0]);
>+			if (taskComment.getIsPrivate() != null && taskComment.getIsPrivate()) {
>+				if (privateFont == null) {
>+					Font a = formHyperlink.getFont();
>+					FontData[] fd = a.getFontData();
>+					for (FontData fontData : fd) {
>+						fontData.setStyle(SWT.ITALIC | SWT.BOLD);
> 					}
>-					formHyperlink.setFont(privateFont);
>-					toolTipText = NLS.bind(Messages.TaskEditorCommentPart_Privat_Comment_ToolTip_Text, toolTipText);
>+					privateFont = new Font(formHyperlink.getDisplay(), fd);
> 				}
>+				formHyperlink.setFont(privateFont);
>+				toolTipText = NLS.bind(Messages.TaskEditorCommentPart_Privat_Comment_ToolTip_Text, toolTipText);
>+			} else {
>+				formHyperlink.setFont(commentComposite.getFont());
> 			}
> 			formHyperlink.setToolTipText(toolTipText);
>

Actions: View | Diff

Attachments on bug 345847: 195783 | 195784 | 196286 | 196287 | 196930 | 196955