Attachment 196225 Details for Bug 346626 – Proposed fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed fix

Bug-346626.patch (text/plain), 2.25 KB, created by Ivan Furnadjiev

on 2011-05-20 10:47:43 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2011-05-20 10:47:43 EDT

Size: 2.25 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/rwt/DNDSupport.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/rwt/DNDSupport.js,v
>retrieving revision 1.14.2.1
>diff -u -r1.14.2.1 DNDSupport.js
>--- js/org/eclipse/rwt/DNDSupport.js	18 May 2011 08:47:26 -0000	1.14.2.1
>+++ js/org/eclipse/rwt/DNDSupport.js	20 May 2011 14:42:43 -0000
>@@ -110,6 +110,7 @@
>       }
>       this._sendDragSourceEvent( target, "dragFinished", mouseEvent );
>       this._cleanUp();
>+      event.stopPropagation();
>     },
> 
>     _sendDragSourceEvent : function( widget, type, qxDomEvent ) {
>#P org.eclipse.rap.rwt.q07.jstest
>Index: js/org/eclipse/rwt/test/tests/DNDTest.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt.test/org.eclipse.rap.rwt.q07.jstest/js/org/eclipse/rwt/test/tests/DNDTest.js,v
>retrieving revision 1.16.2.2
>diff -u -r1.16.2.2 DNDTest.js
>--- js/org/eclipse/rwt/test/tests/DNDTest.js	18 May 2011 13:15:33 -0000	1.16.2.2
>+++ js/org/eclipse/rwt/test/tests/DNDTest.js	20 May 2011 14:42:44 -0000
>@@ -101,6 +101,25 @@
>       testUtil.flush();
>     },
> 
>+    testDragEndPropagation : function() {
>+      var dndSupport = org.eclipse.rwt.DNDSupport.getInstance();
>+      var testUtil = org.eclipse.rwt.test.fixture.TestUtil;
>+      var leftButton = qx.event.type.MouseEvent.buttons.left;
>+      var log = [];
>+      testUtil.getDocument().addEventListener( "dragend", function( event ) {
>+        log.push( event );
>+      } );
>+      var source = this.createSource();
>+      var node = source._getTargetNode();
>+      testUtil.fakeMouseEventDOM( node, "mousedown", leftButton, 11, 11 );
>+      testUtil.fakeMouseEventDOM( node, "mousemove", leftButton, 19, 19 );
>+      testUtil.fakeMouseEventDOM( node, "mouseup", leftButton, 19, 19 );
>+      assertEquals( 0, log.length );
>+      dndSupport.deregisterDragSource( source );
>+      source.destroy();
>+      testUtil.flush();
>+    },
>+
>     testDragStartAndCancel : function() {
>       var testUtil = org.eclipse.rwt.test.fixture.TestUtil;
>       var dndSupport = org.eclipse.rwt.DNDSupport.getInstance();

Actions: View | Diff

Attachments on bug 346626: 196225