Attachment 195829 Details for Bug 346059 – fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix

ComboFocusFix.patch (text/plain), 3.58 KB, created by Tim Buschtoens

on 2011-05-17 06:07:13 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Buschtoens

Created: 2011-05-17 06:07:13 EDT

Size: 3.58 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Combo.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Combo.js,v
>retrieving revision 1.56
>diff -u -r1.56 Combo.js
>--- js/org/eclipse/swt/widgets/Combo.js	26 Apr 2011 13:31:32 -0000	1.56
>+++ js/org/eclipse/swt/widgets/Combo.js	17 May 2011 10:05:51 -0000
>@@ -75,14 +75,13 @@
>     // Init events
>     this.addEventListener( "appear", this._onAppear, this );
>     this.addEventListener( "focusin", this._onFocusIn, this );
>+    this.addEventListener( "blur", this._onBlur, this );
>     this.addEventListener( "changeWidth", this._onChangeSize, this );
>     this.addEventListener( "changeHeight", this._onChangeSize, this );
>     this.addEventListener( "contextmenu", this._onContextMenu, this );
>     this.addEventListener( "changeFont", this._onChangeFont, this );
>     this.addEventListener( "changeTextColor", this._onChangeTextColor, this );
>-    this.addEventListener( "changeBackgroundColor",
>-                           this._onChangeBackgroundColor, 
>-                           this );
>+    this.addEventListener( "changeBackgroundColor", this._onChangeBackgroundColor, this );
>     this.addEventListener( "changeVisibility", this._onChangeVisibility, this );
>     // Mouse events
>     this.addEventListener( "mousedown", this._onMouseDown, this );
>@@ -111,9 +110,7 @@
>     this.removeEventListener( "contextmenu", this._onContextMenu, this );
>     this.removeEventListener( "changeFont", this._onChangeFont, this );
>     this.removeEventListener( "changeTextColor", this._onChangeTextColor, this );
>-    this.removeEventListener( "changeBackgroundColor",
>-                              this._onChangeBackgroundColor, 
>-                              this );
>+    this.removeEventListener( "changeBackgroundColor", this._onChangeBackgroundColor, this );
>     this.removeEventListener( "changeVisibility", this._onChangeVisibility, this );
>     this.removeEventListener( "mousedown", this._onMouseDown, this );
>     this.removeEventListener( "mouseup", this._onMouseUp, this );
>@@ -562,9 +559,7 @@
>           }
>           break;
>       }
>-      if(    this._field.isCreated()
>-          && !org.eclipse.swt.EventUtil.getSuspended() ) 
>-      {
>+      if( this._field.isCreated() && !org.eclipse.swt.EventUtil.getSuspended() ) {
>         this._handleSelectionChange();
>       }
>     },
>#P org.eclipse.rap.rwt.q07.jstest
>Index: js/org/eclipse/rwt/test/tests/ComboTest.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt.test/org.eclipse.rap.rwt.q07.jstest/js/org/eclipse/rwt/test/tests/ComboTest.js,v
>retrieving revision 1.11
>diff -u -r1.11 ComboTest.js
>--- js/org/eclipse/rwt/test/tests/ComboTest.js	26 Apr 2011 13:31:25 -0000	1.11
>+++ js/org/eclipse/rwt/test/tests/ComboTest.js	17 May 2011 10:05:52 -0000
>@@ -34,6 +34,19 @@
>       combo.destroy();
>     },
> 
>+    testCloseListOnBlur : function() {
>+      var testUtil = org.eclipse.rwt.test.fixture.TestUtil;
>+      var combo = this._createDefaultCombo();
>+      combo.focus();
>+      combo.setListVisible( true );
>+      testUtil.flush();
>+      assertTrue( combo._list.isSeeable() );
>+      combo.blur();
>+      testUtil.flush();
>+      assertFalse( combo._list.isSeeable() );
>+      combo.destroy();
>+    },
>+
>     testItems : function() {
>       var testUtil = org.eclipse.rwt.test.fixture.TestUtil;
>       var combo = this._createDefaultCombo();

Flags:

ivan: review+

Actions: View | Diff

Attachments on bug 346059: 195829