Attachment 195594 Details for Bug 343862 – Need to complete RequestMonitors

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Need to complete RequestMonitors

z.infinite2.patch (text/plain), 2.00 KB, created by Marc Khouzam

on 2011-05-13 10:29:20 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Khouzam

Created: 2011-05-13 10:29:20 EDT

Size: 2.00 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.cdt.dsf.gdb
>Index: src/org/eclipse/cdt/dsf/gdb/service/GDBRunControl_7_0_NS.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBRunControl_7_0_NS.java,v
>retrieving revision 1.35
>diff -u -r1.35 GDBRunControl_7_0_NS.java
>--- src/org/eclipse/cdt/dsf/gdb/service/GDBRunControl_7_0_NS.java	13 May 2011 11:13:02 -0000	1.35
>+++ src/org/eclipse/cdt/dsf/gdb/service/GDBRunControl_7_0_NS.java	13 May 2011 14:27:17 -0000
>@@ -1153,7 +1153,13 @@
> 					// If we don't, we risk an infinite loop where we try, over and over
> 					// to perform an operation that keeps on failing.
> 					fOngoingOperation = false;
>-					fOperationsPending.clear();
>+
>+					// Complete each rm of the cancelled operations
>+					while (fOperationsPending.size() > 0) {
>+						RequestMonitor rm = fOperationsPending.poll().rm;
>+						rm.setStatus(getStatus());
>+						rm.done();
>+					}
> 					super.handleFailure();
> 				}
> 			};
>Index: src/org/eclipse/cdt/dsf/mi/service/MIRunControl.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIRunControl.java,v
>retrieving revision 1.36
>diff -u -r1.36 MIRunControl.java
>--- src/org/eclipse/cdt/dsf/mi/service/MIRunControl.java	13 May 2011 11:13:02 -0000	1.36
>+++ src/org/eclipse/cdt/dsf/mi/service/MIRunControl.java	13 May 2011 14:27:17 -0000
>@@ -1156,7 +1156,14 @@
> 					// If we don't, we risk an infinite loop where we try, over and over
> 					// to perform an operation that keeps on failing.
> 					fOngoingOperation = false;
>-					fOperationsPending.clear();
>+					
>+					// Complete each rm of the cancelled operations
>+					while (fOperationsPending.size() > 0) {
>+						RequestMonitor rm = fOperationsPending.poll().rm;
>+						rm.setStatus(getStatus());
>+						rm.done();
>+					}
>+
> 					super.handleFailure();
> 				}
> 			};

Flags:

marc.khouzam: iplog-

Actions: View | Diff

Attachments on bug 343862: 195580 | 195594