Attachment 195284 Details for Bug 345347 – Disallow context menu contributions from other plugins.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Disallow context menu contributions from other plugins.

bug_345347.txt (text/plain), 1.38 KB, created by Shenxue Zhou

on 2011-05-10 19:10:37 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Shenxue Zhou

Created: 2011-05-10 19:10:37 EDT

Size: 1.38 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.graphiti.ui
>Index: src/org/eclipse/graphiti/ui/internal/editor/DiagramEditorInternal.java
>===================================================================
>RCS file: /cvsroot/modeling/org.eclipse.gmp/org.eclipse.gmp.graphiti/plugins/org.eclipse.graphiti.ui/src/org/eclipse/graphiti/ui/internal/editor/DiagramEditorInternal.java,v
>retrieving revision 1.28
>diff -u -r1.28 DiagramEditorInternal.java
>--- src/org/eclipse/graphiti/ui/internal/editor/DiagramEditorInternal.java	11 Apr 2011 11:56:27 -0000	1.28
>+++ src/org/eclipse/graphiti/ui/internal/editor/DiagramEditorInternal.java	10 May 2011 23:08:11 -0000
>@@ -393,6 +393,10 @@
> 		return new DiagramEditorContextMenuProvider(getGraphicalViewer(), getActionRegistry(), getConfigurationProvider());
> 	}
> 
>+	protected boolean shouldRegisterContextMenu() {
>+		return true;
>+	}
>+	
> 	/**
> 	 * Creates the GraphicalViewer AND navigation-bar on the specified
> 	 * <code>Composite</code>.
>@@ -1161,7 +1165,9 @@
> 			getGraphicalViewer().setContextMenu(contextMenuProvider);
> 			// the registration allows an extension of the context-menu by other
> 			// plugins
>-			getSite().registerContextMenu(contextMenuProvider, getGraphicalViewer());
>+			if (shouldRegisterContextMenu()) {
>+				getSite().registerContextMenu(contextMenuProvider, getGraphicalViewer());
>+			}
> 		}
> 
> 		// set contents

Flags:

michael.wenz: iplog+

Actions: View | Diff

Attachments on bug 345347: 195284