Attachment 194829 Details for Bug 344669 – Some more locations to apply that pattern

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Some more locations to apply that pattern

clipboard.txt (text/plain), 1.77 KB, created by Erdal Karaca

on 2011-05-05 09:23:45 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Erdal Karaca

Created: 2011-05-05 09:23:45 EDT

Size: 1.77 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.net4j.db
>Index: src/org/eclipse/net4j/db/DBUtil.java
>===================================================================
>--- src/org/eclipse/net4j/db/DBUtil.java	(revision 7648)
>+++ src/org/eclipse/net4j/db/DBUtil.java	(working copy)
>@@ -440,16 +440,12 @@
>   public static long selectMaximumLong(Connection connection, IDBField field, String... where) throws DBException
>   {
>     Number number = getFunctionResult(connection, field, "MAX", where); //$NON-NLS-1$
>-    if (number instanceof Long)
>-    {
>-      return (Long)number;
>-    }
>-    else if (number == null)
>+    if (number == null)
>     {
>       return 0L;
>     }
> 
>-    throw new DBException("Not a long number: " + number); //$NON-NLS-1$
>+    return number.longValue();
>   }
> 
>   private static Number getFunctionResult(Connection connection, IDBField field, String function, String... where)
>#P org.eclipse.emf.cdo.server.db
>Index: src/org/eclipse/emf/cdo/server/internal/db/MetaDataManager.java
>===================================================================
>--- src/org/eclipse/emf/cdo/server/internal/db/MetaDataManager.java	(revision 7648)
>+++ src/org/eclipse/emf/cdo/server/internal/db/MetaDataManager.java	(working copy)
>@@ -352,8 +352,8 @@
>       public boolean handle(int row, final Object... values)
>       {
>         InternalCDOPackageUnit packageUnit = createPackageUnit();
>-        packageUnit.setOriginalType(CDOPackageUnit.Type.values()[(Integer)values[1]]);
>-        packageUnit.setTimeStamp((Long)values[2]);
>+        packageUnit.setOriginalType(CDOPackageUnit.Type.values()[((Number)values[1]).intValue()]);
>+        packageUnit.setTimeStamp(((Number)values[2]).longValue());
>         packageUnits.put((String)values[0], packageUnit);
>         return true;
>       }

Actions: View | Diff

Attachments on bug 344669: 194680 | 194681 | 194829