Attachment 193575 Details for Bug 335779 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

Bug-335779.patch (text/plain), 1.60 KB, created by Ivan Furnadjiev

on 2011-04-19 09:02:37 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2011-04-19 09:02:37 EDT

Size: 1.60 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/qx/ui/form/TextField.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/qx/ui/form/TextField.js,v
>retrieving revision 1.4
>diff -u -r1.4 TextField.js
>--- js/qx/ui/form/TextField.js	31 Mar 2011 15:15:15 -0000	1.4
>+++ js/qx/ui/form/TextField.js	19 Apr 2011 12:43:33 -0000
>@@ -60,7 +60,10 @@
>     // [rst] Catch backspace in readonly text fields to prevent browser default
>     // action (which commonly triggers a history step back)
>     // See https://bugs.eclipse.org/bugs/show_bug.cgi?id=178320
>-    this.addEventListener("keydown", this._onkeydown);
>+    this.addEventListener( "keydown", this._onkeydown );
>+    // [if] Catch arrow keys in enabled text fields to prevent their propagation to the parent
>+    // see https://bugs.eclipse.org/bugs/show_bug.cgi?id=335779
>+    this.addEventListener( "keypress", this._onkeypress );
>   },
> 
> 
>@@ -972,6 +975,18 @@
>       }
>     },
> 
>+    // [if] Catch arrow keys in enabled text fields to prevent their propagation to the parent
>+    // see https://bugs.eclipse.org/bugs/show_bug.cgi?id=335779
>+    _onkeypress : function( e ) {
>+      if( (  e.getKeyIdentifier() == "Left"
>+          || e.getKeyIdentifier() == "Right"
>+          || e.getKeyIdentifier() == "Up"
>+          || e.getKeyIdentifier() == "Down" )
>+          && this.getEnabled() ) {
>+        e.stopPropagation();
>+      }
>+    },
>+
>     /*
>     ---------------------------------------------------------------------------
>       CROSS-BROWSER SELECTION HANDLING

Actions: View | Diff

Attachments on bug 335779: 193575