Attachment 192991 Details for Bug 339171 – Interpret Bugzilla dependson as a list

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Interpret Bugzilla dependson as a list

clipboard.txt (text/plain), 3.78 KB, created by Sam Davis

on 2011-04-11 20:26:23 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Davis

Created: 2011-04-11 20:26:23 EDT

Size: 3.78 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.bugzilla.core
>Index: src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaTaskDataHandler.java
>===================================================================
>RCS file: /cvsroot/mylyn/org.eclipse.mylyn.tasks/org.eclipse.mylyn.bugzilla.core/src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaTaskDataHandler.java,v
>retrieving revision 1.120
>diff -u -r1.120 BugzillaTaskDataHandler.java
>--- src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaTaskDataHandler.java	4 Mar 2011 21:43:33 -0000	1.120
>+++ src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaTaskDataHandler.java	12 Apr 2011 00:23:00 -0000
>@@ -235,6 +235,9 @@
> 				attribute.getMetaData().setType(bugAttribute.getType());
> 				attribute.getMetaData().setReadOnly(bugAttribute.isReadOnly());
> 				attribute.getMetaData().setKind(bugAttribute.getKind());
>+				if (bugAttribute == BugzillaAttribute.DEPENDSON) {
>+					attribute.getMetaData().putValue(TaskAttribute.META_IS_LIST, "true"); //$NON-NLS-1$
>+				}
> 			}
> 		}
> 	}
>@@ -757,6 +760,9 @@
> 				.setKind(key.getKind())
> 				.setLabel(key.toString())
> 				.setType(key.getType());
>+		if (key == BugzillaAttribute.DEPENDSON) {
>+			attribute.getMetaData().putValue(TaskAttribute.META_IS_LIST, "true"); //$NON-NLS-1$
>+		}
> 		return attribute;
> 	}
> 
>#P org.eclipse.mylyn.tasks.core
>Index: src/org/eclipse/mylyn/internal/tasks/core/data/TaskAttributeDiff.java
>===================================================================
>RCS file: /cvsroot/mylyn/org.eclipse.mylyn.tasks/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/internal/tasks/core/data/TaskAttributeDiff.java,v
>retrieving revision 1.2
>diff -u -r1.2 TaskAttributeDiff.java
>--- src/org/eclipse/mylyn/internal/tasks/core/data/TaskAttributeDiff.java	2 Mar 2011 03:43:04 -0000	1.2
>+++ src/org/eclipse/mylyn/internal/tasks/core/data/TaskAttributeDiff.java	12 Apr 2011 00:23:00 -0000
>@@ -12,6 +12,7 @@
> package org.eclipse.mylyn.internal.tasks.core.data;
> 
> import java.util.ArrayList;
>+import java.util.Arrays;
> import java.util.Collections;
> import java.util.List;
> 
>@@ -87,6 +88,10 @@
> 	}
> 
> 	public List<String> getNewValues() {
>+		if (newValues.size() == 1 && newAttribute != null
>+				&& Boolean.parseBoolean(newAttribute.getMetaData().getValue(TaskAttribute.META_IS_LIST))) {
>+			return Arrays.asList(newValues.get(0).split(", ")); //$NON-NLS-1$
>+		}
> 		return newValues;
> 	}
> 
>@@ -95,6 +100,10 @@
> 	}
> 
> 	public List<String> getOldValues() {
>+		if (oldValues.size() == 1 && oldAttribute != null
>+				&& Boolean.parseBoolean(oldAttribute.getMetaData().getValue(TaskAttribute.META_IS_LIST))) {
>+			return Arrays.asList(oldValues.get(0).split(", ")); //$NON-NLS-1$
>+		}
> 		return oldValues;
> 	}
> 
>Index: src/org/eclipse/mylyn/tasks/core/data/TaskAttribute.java
>===================================================================
>RCS file: /cvsroot/mylyn/org.eclipse.mylyn.tasks/org.eclipse.mylyn.tasks.core/src/org/eclipse/mylyn/tasks/core/data/TaskAttribute.java,v
>retrieving revision 1.47
>diff -u -r1.47 TaskAttribute.java
>--- src/org/eclipse/mylyn/tasks/core/data/TaskAttribute.java	2 Feb 2011 06:44:41 -0000	1.47
>+++ src/org/eclipse/mylyn/tasks/core/data/TaskAttribute.java	12 Apr 2011 00:23:01 -0000
>@@ -126,6 +126,13 @@
> 	public static final String META_READ_ONLY = "task.meta.readOnly"; //$NON-NLS-1$
> 
> 	/**
>+	 * Boolean indicating whether attribute value should be interpreted as a list delimited by ", ".
>+	 * 
>+	 * @since 3.6
>+	 */
>+	public static final String META_IS_LIST = "task.meta.isList"; //$NON-NLS-1$
>+
>+	/**
> 	 * Key for the meta datum that determines if an attribute is disabled. This is used to indicate that an attribute
> 	 * should not be modified, e.g. due to work-flow state but it may still be generally writeable.
> 	 *

Actions: View | Diff

Attachments on bug 339171: 192984 | 192985 | 192991