Attachment 191127 Details for Bug 298213 – this patch fixes bug 288943

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] this patch fixes bug 288943

fixBug288943_codeCompletionProposalsForReturnAndParameterTypes.patch (text/plain), 2.14 KB, created by Benedikt Niehues

on 2011-03-14 11:13:56 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Benedikt Niehues

Created: 2011-03-14 11:13:56 EDT

Size: 2.14 KB

patch

obsolete

>From 701df6441d51e773e78bdb450af49964b76a28b9 Mon, 14 Mar 2011 16:12:41 +0100
>From: Benedikt Niehues <benedikt.niehues@itemis.de>
>Date: Mon, 14 Mar 2011 16:11:24 +0100
>Subject: [PATCH] provide codeCompletion in extensionDefinitions for Return- and ParameterTypes
>
>diff --git a/plugins/org.eclipse.xtend.ui/src/org/eclipse/xtend/ui/editor/codeassist/XtendContentAssistProcessor.java b/plugins/org.eclipse.xtend.ui/src/org/eclipse/xtend/ui/editor/codeassist/XtendContentAssistProcessor.java
>index 9374da9..ea6e69b 100644
>--- a/plugins/org.eclipse.xtend.ui/src/org/eclipse/xtend/ui/editor/codeassist/XtendContentAssistProcessor.java
>+++ b/plugins/org.eclipse.xtend.ui/src/org/eclipse/xtend/ui/editor/codeassist/XtendContentAssistProcessor.java
>@@ -88,7 +88,11 @@
> 			ctx = FastAnalyzer.computeExecutionContext(part, ctx, extensions);
> 			proposals = (List<? extends ICompletionProposal>) new NamespaceProposalComputer().computeProposals(part, ctx, factory);
> 			
>+		} else if (p == Partition.DEFAULT){
>+			ctx = FastAnalyzer.computeExecutionContext(part, ctx, extensions);
>+			proposals = (List<? extends ICompletionProposal>) new TypeProposalComputer().computeProposals(part, ctx, factory);
> 		}
>+		
> 		Collections.sort(proposals, new ProposalComparator());
> 		return proposals.toArray(new ICompletionProposal[proposals.size()]);
> 	}
>diff --git a/plugins/org.eclipse.xtend/src/org/eclipse/internal/xtend/xtend/codeassist/FastAnalyzer.java b/plugins/org.eclipse.xtend/src/org/eclipse/internal/xtend/xtend/codeassist/FastAnalyzer.java
>index 786cac6..305a177 100644
>--- a/plugins/org.eclipse.xtend/src/org/eclipse/internal/xtend/xtend/codeassist/FastAnalyzer.java
>+++ b/plugins/org.eclipse.xtend/src/org/eclipse/internal/xtend/xtend/codeassist/FastAnalyzer.java
>@@ -215,7 +215,7 @@
> 			final String str, ExecutionContext ctx,
> 			final List<Extension> extensions) {
> 		final Partition p = computePartition(str);
>-		if (p == Partition.EXPRESSION || p == Partition.TYPE_DECLARATION) {
>+		if (p == Partition.EXPRESSION || p == Partition.TYPE_DECLARATION || p == Partition.DEFAULT) {
> 
> 			final List<String> imports = findImports(str);
> 			final List<String> extensionImports = findExtensions(str);

Actions: View | Diff

Attachments on bug 298213: 191127 | 191128