Attachment 187357 Details for Bug 237306 – Fully enable the user of --thread-group

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fully enable the user of --thread-group

zpatch.txt (text/plain), 8.13 KB, created by Marc Khouzam

on 2011-01-22 06:31:20 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Khouzam

Created: 2011-01-22 06:31:20 EST

Size: 8.13 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.cdt.dsf.gdb
>Index: src/org/eclipse/cdt/dsf/mi/service/command/commands/CLICommand.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/CLICommand.java,v
>retrieving revision 1.2
>diff -u -r1.2 CLICommand.java
>--- src/org/eclipse/cdt/dsf/mi/service/command/commands/CLICommand.java	3 Jun 2010 00:09:35 -0000	1.2
>+++ src/org/eclipse/cdt/dsf/mi/service/command/commands/CLICommand.java	22 Jan 2011 11:15:58 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2009 QNX Software Systems and others.
>+ * Copyright (c) 2000, 2011 QNX Software Systems and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -26,5 +26,7 @@
>     
>     @Override
> 	public boolean supportsThreadAndFrameOptions() { return false; }
>-
>+    
>+    @Override
>+    public boolean supportsThreadGroupOption() { return false; }
> }
>Index: src/org/eclipse/cdt/dsf/mi/service/command/commands/MICommand.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MICommand.java,v
>retrieving revision 1.3
>diff -u -r1.3 MICommand.java
>--- src/org/eclipse/cdt/dsf/mi/service/command/commands/MICommand.java	16 Dec 2010 03:13:31 -0000	1.3
>+++ src/org/eclipse/cdt/dsf/mi/service/command/commands/MICommand.java	22 Jan 2011 11:15:58 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2010 QNX Software Systems and others.
>+ * Copyright (c) 2000, 2011 QNX Software Systems and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -153,14 +153,14 @@
>         StringBuffer command = new StringBuffer(getOperation());
>         
>         // Add the --thread option
>-        if (supportsThreadAndFrameOptions() && threadId != null) {
>+        if (supportsThreadAndFrameOptions() && threadId != null && threadId.trim().length() > 0) {
>         	command.append(" --thread " + threadId); //$NON-NLS-1$
> 
>         	// Add the --frame option, but only if we are using the --thread option
>         	if (frameId >= 0) {
>         		command.append(" --frame " + frameId); //$NON-NLS-1$
>         	}
>-        } else if (supportsThreadGroupOption() && groupId != null) {
>+        } else if (supportsThreadGroupOption() && groupId != null && groupId.trim().length() > 0) {
>         	// The --thread-group option is only allowed if we are not using the --thread option
>         	command.append(" --thread-group " + groupId); //$NON-NLS-1$
>         }
>@@ -257,7 +257,7 @@
>     /**
>      * @since 4.0
>      */
>-    public boolean supportsThreadGroupOption() { return false; }
>+    public boolean supportsThreadGroupOption() { return true; }
>     
>     /**
>      * Compare commands based on the MI command string that they generate, 
>Index: src/org/eclipse/cdt/dsf/mi/service/command/commands/MIFileExecAndSymbols.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIFileExecAndSymbols.java,v
>retrieving revision 1.5
>diff -u -r1.5 MIFileExecAndSymbols.java
>--- src/org/eclipse/cdt/dsf/mi/service/command/commands/MIFileExecAndSymbols.java	16 Dec 2010 03:13:31 -0000	1.5
>+++ src/org/eclipse/cdt/dsf/mi/service/command/commands/MIFileExecAndSymbols.java	22 Jan 2011 11:15:58 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2008, 2010 Ericsson and others.
>+ * Copyright (c) 2008, 2011 Ericsson and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -56,9 +56,4 @@
>     public MIFileExecAndSymbols(IMIContainerDMContext dmc, String file) {
>         super(dmc, "-file-exec-and-symbols", null, file == null ? null : new String[] {file}); //$NON-NLS-1$
>     }
>-
>-    @Override
>-    public boolean supportsThreadGroupOption() {
>-    	return true;
>-    }
> }
>Index: src/org/eclipse/cdt/dsf/mi/service/command/commands/MITargetAttach.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MITargetAttach.java,v
>retrieving revision 1.3
>diff -u -r1.3 MITargetAttach.java
>--- src/org/eclipse/cdt/dsf/mi/service/command/commands/MITargetAttach.java	16 Dec 2010 03:13:31 -0000	1.3
>+++ src/org/eclipse/cdt/dsf/mi/service/command/commands/MITargetAttach.java	22 Jan 2011 11:15:58 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2008, 2010 Ericsson and others.
>+ * Copyright (c) 2008, 2011 Ericsson and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -45,9 +45,4 @@
> 	public MITargetAttach(IMIContainerDMContext ctx, String pid) {
> 		super(ctx, "-target-attach", new String[] { pid }); //$NON-NLS-1$
> 	}
>-	
>-    @Override
>-    public boolean supportsThreadGroupOption() {
>-    	return true;
>-    }
> }
>Index: src/org/eclipse/cdt/dsf/mi/service/command/commands/MITargetDetach.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MITargetDetach.java,v
>retrieving revision 1.3
>diff -u -r1.3 MITargetDetach.java
>--- src/org/eclipse/cdt/dsf/mi/service/command/commands/MITargetDetach.java	16 Dec 2010 03:13:31 -0000	1.3
>+++ src/org/eclipse/cdt/dsf/mi/service/command/commands/MITargetDetach.java	22 Jan 2011 11:15:58 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2008, 2010 Ericsson and others.
>+ * Copyright (c) 2008, 2011 Ericsson and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -49,10 +49,4 @@
> 	public MITargetDetach(IMIContainerDMContext ctx) {
> 		super(ctx, "-target-detach"); //$NON-NLS-1$
> 	}
>-	
>-	@Override
>-	public boolean supportsThreadGroupOption() {
>-		return true;
>-	}
>-
> }
>Index: src/org/eclipse/cdt/dsf/mi/service/command/commands/RawCommand.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/RawCommand.java,v
>retrieving revision 1.2
>diff -u -r1.2 RawCommand.java
>--- src/org/eclipse/cdt/dsf/mi/service/command/commands/RawCommand.java	3 Jun 2010 00:09:35 -0000	1.2
>+++ src/org/eclipse/cdt/dsf/mi/service/command/commands/RawCommand.java	22 Jan 2011 11:15:58 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2009 QNX Software Systems and others.
>+ * Copyright (c) 2000, 2011 QNX Software Systems and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -30,6 +30,9 @@
>     @Override
> 	public boolean supportsThreadAndFrameOptions() { return false; }
> 
>+    @Override
>+    public boolean supportsThreadGroupOption() { return false; }
>+    
>     /* (non-Javadoc)
>      * @see org.eclipse.cdt.debug.mi.core.command.Command#getMIOutput()
>      */

Flags:

marc.khouzam: iplog-

Actions: View | Diff

Attachments on bug 237306: 166478 | 167440 | 168092 | 168093 | 168510 | 176501 | 178929 | 179595 | 179596 | 179913 | 182593 | 184318 | 185285 | 185617 | 185691 | 186266 | 187326 | 187357 | 190931 | 190997