Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
View | Details | Raw Unified | Return to bug 237306 | Differences between
and this patch

Collapse All | Expand All

(-)src/org/eclipse/cdt/dsf/mi/service/command/commands/CLICommand.java (-2 / +4 lines)
Lines 1-5 Link Here
1
/*******************************************************************************
1
/*******************************************************************************
2
 * Copyright (c) 2000, 2009 QNX Software Systems and others.
2
 * Copyright (c) 2000, 2011 QNX Software Systems and others.
3
 * All rights reserved. This program and the accompanying materials
3
 * All rights reserved. This program and the accompanying materials
4
 * are made available under the terms of the Eclipse Public License v1.0
4
 * are made available under the terms of the Eclipse Public License v1.0
5
 * which accompanies this distribution, and is available at
5
 * which accompanies this distribution, and is available at
Lines 26-30 Link Here
26
    
26
    
27
    @Override
27
    @Override
28
	public boolean supportsThreadAndFrameOptions() { return false; }
28
	public boolean supportsThreadAndFrameOptions() { return false; }
29
29
    
30
    @Override
31
    public boolean supportsThreadGroupOption() { return false; }
30
}
32
}
(-)src/org/eclipse/cdt/dsf/mi/service/command/commands/MICommand.java (-4 / +4 lines)
Lines 1-5 Link Here
1
/*******************************************************************************
1
/*******************************************************************************
2
 * Copyright (c) 2000, 2010 QNX Software Systems and others.
2
 * Copyright (c) 2000, 2011 QNX Software Systems and others.
3
 * All rights reserved. This program and the accompanying materials
3
 * All rights reserved. This program and the accompanying materials
4
 * are made available under the terms of the Eclipse Public License v1.0
4
 * are made available under the terms of the Eclipse Public License v1.0
5
 * which accompanies this distribution, and is available at
5
 * which accompanies this distribution, and is available at
Lines 153-166 Link Here
153
        StringBuffer command = new StringBuffer(getOperation());
153
        StringBuffer command = new StringBuffer(getOperation());
154
        
154
        
155
        // Add the --thread option
155
        // Add the --thread option
156
        if (supportsThreadAndFrameOptions() && threadId != null) {
156
        if (supportsThreadAndFrameOptions() && threadId != null && threadId.trim().length() > 0) {
157
        	command.append(" --thread " + threadId); //$NON-NLS-1$
157
        	command.append(" --thread " + threadId); //$NON-NLS-1$
158
158
159
        	// Add the --frame option, but only if we are using the --thread option
159
        	// Add the --frame option, but only if we are using the --thread option
160
        	if (frameId >= 0) {
160
        	if (frameId >= 0) {
161
        		command.append(" --frame " + frameId); //$NON-NLS-1$
161
        		command.append(" --frame " + frameId); //$NON-NLS-1$
162
        	}
162
        	}
163
        } else if (supportsThreadGroupOption() && groupId != null) {
163
        } else if (supportsThreadGroupOption() && groupId != null && groupId.trim().length() > 0) {
164
        	// The --thread-group option is only allowed if we are not using the --thread option
164
        	// The --thread-group option is only allowed if we are not using the --thread option
165
        	command.append(" --thread-group " + groupId); //$NON-NLS-1$
165
        	command.append(" --thread-group " + groupId); //$NON-NLS-1$
166
        }
166
        }
Lines 257-263 Link Here
257
    /**
257
    /**
258
     * @since 4.0
258
     * @since 4.0
259
     */
259
     */
260
    public boolean supportsThreadGroupOption() { return false; }
260
    public boolean supportsThreadGroupOption() { return true; }
261
    
261
    
262
    /**
262
    /**
263
     * Compare commands based on the MI command string that they generate, 
263
     * Compare commands based on the MI command string that they generate, 
(-)src/org/eclipse/cdt/dsf/mi/service/command/commands/MIFileExecAndSymbols.java (-6 / +1 lines)
Lines 1-5 Link Here
1
/*******************************************************************************
1
/*******************************************************************************
2
 * Copyright (c) 2008, 2010 Ericsson and others.
2
 * Copyright (c) 2008, 2011 Ericsson and others.
3
 * All rights reserved. This program and the accompanying materials
3
 * All rights reserved. This program and the accompanying materials
4
 * are made available under the terms of the Eclipse Public License v1.0
4
 * are made available under the terms of the Eclipse Public License v1.0
5
 * which accompanies this distribution, and is available at
5
 * which accompanies this distribution, and is available at
Lines 56-64 Link Here
56
    public MIFileExecAndSymbols(IMIContainerDMContext dmc, String file) {
56
    public MIFileExecAndSymbols(IMIContainerDMContext dmc, String file) {
57
        super(dmc, "-file-exec-and-symbols", null, file == null ? null : new String[] {file}); //$NON-NLS-1$
57
        super(dmc, "-file-exec-and-symbols", null, file == null ? null : new String[] {file}); //$NON-NLS-1$
58
    }
58
    }
59
60
    @Override
61
    public boolean supportsThreadGroupOption() {
62
    	return true;
63
    }
64
}
59
}
(-)src/org/eclipse/cdt/dsf/mi/service/command/commands/MITargetAttach.java (-6 / +1 lines)
Lines 1-5 Link Here
1
/*******************************************************************************
1
/*******************************************************************************
2
 * Copyright (c) 2008, 2010 Ericsson and others.
2
 * Copyright (c) 2008, 2011 Ericsson and others.
3
 * All rights reserved. This program and the accompanying materials
3
 * All rights reserved. This program and the accompanying materials
4
 * are made available under the terms of the Eclipse Public License v1.0
4
 * are made available under the terms of the Eclipse Public License v1.0
5
 * which accompanies this distribution, and is available at
5
 * which accompanies this distribution, and is available at
Lines 45-53 Link Here
45
	public MITargetAttach(IMIContainerDMContext ctx, String pid) {
45
	public MITargetAttach(IMIContainerDMContext ctx, String pid) {
46
		super(ctx, "-target-attach", new String[] { pid }); //$NON-NLS-1$
46
		super(ctx, "-target-attach", new String[] { pid }); //$NON-NLS-1$
47
	}
47
	}
48
	
49
    @Override
50
    public boolean supportsThreadGroupOption() {
51
    	return true;
52
    }
53
}
48
}
(-)src/org/eclipse/cdt/dsf/mi/service/command/commands/MITargetDetach.java (-7 / +1 lines)
Lines 1-5 Link Here
1
/*******************************************************************************
1
/*******************************************************************************
2
 * Copyright (c) 2008, 2010 Ericsson and others.
2
 * Copyright (c) 2008, 2011 Ericsson and others.
3
 * All rights reserved. This program and the accompanying materials
3
 * All rights reserved. This program and the accompanying materials
4
 * are made available under the terms of the Eclipse Public License v1.0
4
 * are made available under the terms of the Eclipse Public License v1.0
5
 * which accompanies this distribution, and is available at
5
 * which accompanies this distribution, and is available at
Lines 49-58 Link Here
49
	public MITargetDetach(IMIContainerDMContext ctx) {
49
	public MITargetDetach(IMIContainerDMContext ctx) {
50
		super(ctx, "-target-detach"); //$NON-NLS-1$
50
		super(ctx, "-target-detach"); //$NON-NLS-1$
51
	}
51
	}
52
	
53
	@Override
54
	public boolean supportsThreadGroupOption() {
55
		return true;
56
	}
57
58
}
52
}
(-)src/org/eclipse/cdt/dsf/mi/service/command/commands/RawCommand.java (-1 / +4 lines)
Lines 1-5 Link Here
1
/*******************************************************************************
1
/*******************************************************************************
2
 * Copyright (c) 2000, 2009 QNX Software Systems and others.
2
 * Copyright (c) 2000, 2011 QNX Software Systems and others.
3
 * All rights reserved. This program and the accompanying materials
3
 * All rights reserved. This program and the accompanying materials
4
 * are made available under the terms of the Eclipse Public License v1.0
4
 * are made available under the terms of the Eclipse Public License v1.0
5
 * which accompanies this distribution, and is available at
5
 * which accompanies this distribution, and is available at
Lines 30-35 Link Here
30
    @Override
30
    @Override
31
	public boolean supportsThreadAndFrameOptions() { return false; }
31
	public boolean supportsThreadAndFrameOptions() { return false; }
32
32
33
    @Override
34
    public boolean supportsThreadGroupOption() { return false; }
35
    
33
    /* (non-Javadoc)
36
    /* (non-Javadoc)
34
     * @see org.eclipse.cdt.debug.mi.core.command.Command#getMIOutput()
37
     * @see org.eclipse.cdt.debug.mi.core.command.Command#getMIOutput()
35
     */
38
     */

Return to bug 237306