Attachment 187325 Details for Bug 334809 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

clipboard.txt (text/plain), 1.98 KB, created by Rüdiger Herrmann

on 2011-01-21 15:29:58 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Rüdiger Herrmann

Created: 2011-01-21 15:29:58 EST

Size: 1.98 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/rwt/AsyncKeyEventUtil.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/rwt/AsyncKeyEventUtil.js,v
>retrieving revision 1.16
>diff -u -r1.16 AsyncKeyEventUtil.js
>--- js/org/eclipse/rwt/AsyncKeyEventUtil.js	4 Nov 2010 17:28:30 -0000	1.16
>+++ js/org/eclipse/rwt/AsyncKeyEventUtil.js	21 Jan 2011 20:29:29 -0000
>@@ -183,7 +183,7 @@
>     },
> 
>     _getEventInfo : function( event ) {
>-      return {
>+      result = {
>         target: event.target || event.srcElement,
>         type: event.type,
>         bubbles: event.bubbles,
>@@ -192,11 +192,12 @@
>         altKey:  event.altKey,
>         shiftKey: event.shiftKey,
>         keyCode: event.keyCode,
>-        charCode: event.charCode,
>         isChar: event.isChar,
>         pageX: event.pageX,
>         pageY: event.pageY
>       };
>+      result.charCode = event.type === "keypress" ? event.charCode : 0;
>+      return result;
>     },
> 
>     _checkBufferedEvents : function() {
>Index: js/org/eclipse/rwt/EventHandlerUtil.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/rwt/EventHandlerUtil.js,v
>retrieving revision 1.5
>diff -u -r1.5 EventHandlerUtil.js
>--- js/org/eclipse/rwt/EventHandlerUtil.js	18 Jan 2011 13:16:21 -0000	1.5
>+++ js/org/eclipse/rwt/EventHandlerUtil.js	21 Jan 2011 20:29:29 -0000
>@@ -168,7 +168,8 @@
> 
>     getCharCode : qx.core.Variant.select( "qx.client", {
>       "default" : function( event ) {
>-        return event.charCode !== 13 ? event.charCode : 0;
>+        var hasCharCode = event.type === "keypress" && event.keyCode !== 13;
>+        return hasCharCode ? event.charCode : 0;
>       },
>       "mshtml" : function( event ) {
>         var hasCharCode = event.type === "keypress" && event.keyCode !== 13;

Actions: View | Diff

Attachments on bug 334809: 187325