Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 187325 Details for
Bug 334809
[client] Warning in Firefox Error Console when querying charCode of a key event
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read
this important communication.
[patch]
Proposed patch
clipboard.txt (text/plain), 1.98 KB, created by
RĂ¼diger Herrmann
on 2011-01-21 15:29:58 EST
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
RĂ¼diger Herrmann
Created:
2011-01-21 15:29:58 EST
Size:
1.98 KB
patch
obsolete
>### Eclipse Workspace Patch 1.0 >#P org.eclipse.rap.rwt.q07 >Index: js/org/eclipse/rwt/AsyncKeyEventUtil.js >=================================================================== >RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/rwt/AsyncKeyEventUtil.js,v >retrieving revision 1.16 >diff -u -r1.16 AsyncKeyEventUtil.js >--- js/org/eclipse/rwt/AsyncKeyEventUtil.js 4 Nov 2010 17:28:30 -0000 1.16 >+++ js/org/eclipse/rwt/AsyncKeyEventUtil.js 21 Jan 2011 20:29:29 -0000 >@@ -183,7 +183,7 @@ > }, > > _getEventInfo : function( event ) { >- return { >+ result = { > target: event.target || event.srcElement, > type: event.type, > bubbles: event.bubbles, >@@ -192,11 +192,12 @@ > altKey: event.altKey, > shiftKey: event.shiftKey, > keyCode: event.keyCode, >- charCode: event.charCode, > isChar: event.isChar, > pageX: event.pageX, > pageY: event.pageY > }; >+ result.charCode = event.type === "keypress" ? event.charCode : 0; >+ return result; > }, > > _checkBufferedEvents : function() { >Index: js/org/eclipse/rwt/EventHandlerUtil.js >=================================================================== >RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/rwt/EventHandlerUtil.js,v >retrieving revision 1.5 >diff -u -r1.5 EventHandlerUtil.js >--- js/org/eclipse/rwt/EventHandlerUtil.js 18 Jan 2011 13:16:21 -0000 1.5 >+++ js/org/eclipse/rwt/EventHandlerUtil.js 21 Jan 2011 20:29:29 -0000 >@@ -168,7 +168,8 @@ > > getCharCode : qx.core.Variant.select( "qx.client", { > "default" : function( event ) { >- return event.charCode !== 13 ? event.charCode : 0; >+ var hasCharCode = event.type === "keypress" && event.keyCode !== 13; >+ return hasCharCode ? event.charCode : 0; > }, > "mshtml" : function( event ) { > var hasCharCode = event.type === "keypress" && event.keyCode !== 13;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 334809
: 187325