Attachment 187109 Details for Bug 325923 – patch to not show interrupted exception or operation cancelled exception message

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch to not show interrupted exception or operation cancelled exception message

patch.txt (text/plain), 2.07 KB, created by David McKnight

on 2011-01-19 09:53:12 EST

(hide)

Description:

Filename:

MIME Type:

Creator: David McKnight

Created: 2011-01-19 09:53:12 EST

Size: 2.07 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.ui
>Index: UI/org/eclipse/rse/ui/operations/SystemFetchOperation.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/operations/SystemFetchOperation.java,v
>retrieving revision 1.41
>diff -u -r1.41 SystemFetchOperation.java
>--- UI/org/eclipse/rse/ui/operations/SystemFetchOperation.java	9 Nov 2010 11:55:39 -0000	1.41
>+++ UI/org/eclipse/rse/ui/operations/SystemFetchOperation.java	19 Jan 2011 14:52:32 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2004, 2010 IBM Corporation and others.
>+ * Copyright (c) 2004, 2011 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -26,7 +26,7 @@
>  * David McKnight   (IBM)        - [260777] [ssh] Deadlock when changing selection after multiple hibernate/resume cycles
>  * David McKnight   (IBM)        - [283793] [dstore] Expansion indicator(+) does not reset after no connect
>  * David McKnight   (IBM)        - [316565] Failed to resolve the filter for a non-connected subsystem
>- * David McKnight   (IBM)        - [325923] [dstore] Cancel message not suitable in "Import Host Certificate" window
>+ * David McKnight   (IBM)        - [325923] SystemFetchOperation Cancel message not suitable
>  *******************************************************************************/
> 
> package org.eclipse.rse.ui.operations;
>@@ -318,8 +318,11 @@
> 					return false;
> 				}
> 				catch (Exception e)
>-				{
>-					showOperationErrorMessage(null, e, ss);
>+				{					
>+					// bug 325923 - it's inappropriate to display such messages on cancel
>+					if (!(e instanceof InterruptedException) && !(e instanceof OperationCanceledException)){
>+						showOperationErrorMessage(null, e, ss);
>+					}
> 					return false;
> 				}
> 				finally {

Actions: View | Diff

Attachments on bug 325923: 186183 | 187109