Attachment 186620 Details for Bug 163769 – Fix annotation drawing

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix annotation drawing

patch.txt (text/plain), 2.61 KB, created by Markus Keller

on 2011-01-12 08:22:42 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Markus Keller

Created: 2011-01-12 08:22:42 EST

Size: 2.61 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jface.text
>Index: src/org/eclipse/jface/text/source/SourceViewer.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.text/src/org/eclipse/jface/text/source/SourceViewer.java,v
>retrieving revision 1.94
>diff -u -r1.94 SourceViewer.java
>--- src/org/eclipse/jface/text/source/SourceViewer.java	9 Aug 2010 16:35:25 -0000	1.94
>+++ src/org/eclipse/jface/text/source/SourceViewer.java	12 Jan 2011 13:18:38 -0000
>@@ -157,6 +157,32 @@
> 				int bottomOffset= clArea.y + clArea.height - scrollbarHeight;
> 				int[] arrowHeights= getVerticalScrollArrowHeights(textWidget, bottomOffset);
> 				
>+				/*
>+				 * Goal: Center of thumb should align with center of line mark in overview ruler. 
>+				 */
>+				
>+//				//TODO: should move this into the painter in OverviewRuler
>+//				
>+//				ScrollBar verticalBar= textWidget.getVerticalBar();
>+//				double thumbTrackHeight= verticalBar.getThumbTrackBounds().height;
>+//				double thumbHeight= verticalBar.getThumbBounds().height;
>+//				double textLineCount= Math.max(1, textWidget.getLineCount());
>+//				int topIndex= textWidget.getTopIndex();
>+//				Rectangle clientArea= textWidget.getClientArea();
>+//				int bottomIndex= textWidget.getLineIndex(clientArea.y + clientArea.height);
>+//				double visibleLineCount= bottomIndex - topIndex + 1;
>+//				// (thumbHeight-additionalThumbHeight)/thumbTrackHeight == visibleLineCount/textLineCount:
>+//				double additionalThumbHeight= Math.max(0, thumbHeight - visibleLineCount/textLineCount*thumbTrackHeight);
>+//				
>+//				//TODO:
>+////				System.out.println(additionalThumbHeight);
>+////				fOverviewRuler.getControl().setBackground(fOverviewRuler.getControl().getDisplay().getSystemColor(SWT.COLOR_GREEN));
>+//				
>+//				int overviewRulerX= clArea.x + clArea.width - overviewRulerWidth - 1;
>+//				int overviewRulerY= (int)(clArea.y + arrowHeights[0] + additionalThumbHeight/2d);
>+//				int overviewRulerHeight= (int)(clArea.height - arrowHeights[0] - arrowHeights[1] - additionalThumbHeight - scrollbarHeight);
>+//				fOverviewRuler.getControl().setBounds(overviewRulerX, overviewRulerY, overviewRulerWidth, overviewRulerHeight);
>+				
> 				int overviewRulerX= clArea.x + clArea.width - overviewRulerWidth - 1;
> 				fOverviewRuler.getControl().setBounds(overviewRulerX, clArea.y + arrowHeights[0], overviewRulerWidth, clArea.height - arrowHeights[0] - arrowHeights[1] - scrollbarHeight);
> 				
>@@ -205,7 +231,6 @@
> 				} finally {
> 					textWidget.setSize(originalSize); // also resets scroll bar values
> 				}
>-				return arrowHeights;
> 			}
> 			return arrowHeights;
> 		}

Actions: View | Diff

Attachments on bug 163769: 72050 | 143870 | 144937 | 146934 | 150218 | 150219 | 150488 | 186620 | 186622 | 186755