Attachment 185924 Details for Bug 255619 – proposed patch v1 - patches DebugPlugin.java

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] proposed patch v1 - patches DebugPlugin.java

DebugPlugin.patch.txt (text/plain), 1.65 KB, created by Andre Berg

on 2010-12-31 05:26:42 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Andre Berg

Created: 2010-12-31 05:26:42 EST

Size: 1.65 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.debug.core
>Index: core/org/eclipse/debug/core/DebugPlugin.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.debug.core/core/org/eclipse/debug/core/DebugPlugin.java,v
>retrieving revision 1.169
>diff -u -r1.169 DebugPlugin.java
>--- core/org/eclipse/debug/core/DebugPlugin.java	17 Mar 2010 21:01:15 -0000	1.169
>+++ core/org/eclipse/debug/core/DebugPlugin.java	31 Dec 2010 08:48:52 -0000
>@@ -1267,19 +1267,30 @@
> 				return ""; //$NON-NLS-1$
> 			}
> 			StringBuffer buf= new StringBuffer();
>-			while (ch > 0 && ch != '"') {
>-				if (ch == '\\') {
>-					ch= getNext();
>-					if (ch != '"') {           // Only escape double quotes
>-						buf.append('\\');
>-					} else {
>-						if (Platform.getOS().equals(Constants.OS_WIN32)) {
>-							// @see Bug 26870. Windows requires an extra escape for embedded strings
>+			if (!Platform.getOS().equals(Constants.OS_MACOSX)) {
>+				while (ch > 0 && ch != '"') {
>+					if (ch == '\\') {
>+						ch= getNext();
>+						if (ch != '"') {           // Only escape double quotes
> 							buf.append('\\');
>+						} else {
>+							if (Platform.getOS().equals(Constants.OS_WIN32)) {
>+								// @see Bug 26870. Windows requires an extra escape for embedded strings
>+								buf.append('\\');
>+							}
> 						}
> 					}
>+					if (ch > 0) {
>+						buf.append((char)ch);
>+						ch= getNext();
>+					}
> 				}
>-				if (ch > 0) {
>+			} else {
>+				// @see Bug 255619. Mac OS X requires a slightly different treatment
>+				while (ch > 0 && ch != '"') {
>+					if (ch == '\\') {
>+						ch = getNext();
>+					}
> 					buf.append((char)ch);
> 					ch= getNext();
> 				}

Actions: View | Diff

Attachments on bug 255619: 185923 | 185924 | 186050