Attachment 185790 Details for Bug 332734 – patch V2

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch V2

patch332734V2.txt (text/plain), 2.12 KB, created by Frank Becker

on 2010-12-23 15:49:12 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Frank Becker

Created: 2010-12-23 15:49:12 EST

Size: 2.12 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.tasks.ui
>Index: src/org/eclipse/mylyn/tasks/ui/TaskHyperlinkPresenter.java
>===================================================================
>RCS file: /cvsroot/mylyn/org.eclipse.mylyn.tasks/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/TaskHyperlinkPresenter.java,v
>retrieving revision 1.7
>diff -u -r1.7 TaskHyperlinkPresenter.java
>--- src/org/eclipse/mylyn/tasks/ui/TaskHyperlinkPresenter.java	12 Nov 2010 21:04:30 -0000	1.7
>+++ src/org/eclipse/mylyn/tasks/ui/TaskHyperlinkPresenter.java	23 Dec 2010 20:45:51 -0000
>@@ -51,6 +51,8 @@
> 
> 	private ITextViewer textViewer;
> 
>+	private String oldToolTip;
>+
> 	/**
> 	 * @see DefaultHyperlinkPresenter#DefaultHyperlinkPresenter(IPreferenceStore)
> 	 */
>@@ -97,8 +99,13 @@
> 
> 	@Override
> 	public void showHyperlinks(IHyperlink[] hyperlinks) {
>+		showHyperlinks(hyperlinks, false);
>+	}
>+
>+	@Override
>+	public void showHyperlinks(IHyperlink[] hyperlinks, boolean takesFocusWhenVisible) {
> 		if (hyperlinks.length > 1) {
>-			super.showHyperlinks(hyperlinks);
>+			super.showHyperlinks(hyperlinks, takesFocusWhenVisible);
> 		} else {
> 			activeRegion = null;
> 			if (hyperlinks.length > 0 && hyperlinks[0] instanceof TaskHyperlink) {
>@@ -118,6 +125,7 @@
> 					activeRegion = hyperlink.getHyperlinkRegion();
> 					if (textViewer != null && textViewer.getTextWidget() != null
> 							&& !textViewer.getTextWidget().isDisposed()) {
>+						oldToolTip = textViewer.getTextWidget().getToolTipText();
> 						if (task == null) {
> 							String taskLabel = TasksUiInternal.getTaskPrefix(hyperlink.getRepository()
> 									.getConnectorKind());
>@@ -132,7 +140,7 @@
> 					}
> 				}
> 			}
>-			super.showHyperlinks(hyperlinks);
>+			super.showHyperlinks(hyperlinks, takesFocusWhenVisible);
> 		}
> 	}
> 
>@@ -140,7 +148,7 @@
> 	public void hideHyperlinks() {
> 		if (currentTaskHyperlink != null) {
> 			if (textViewer != null && textViewer.getTextWidget() != null && !textViewer.getTextWidget().isDisposed()) {
>-				textViewer.getTextWidget().setToolTipText(null);
>+				textViewer.getTextWidget().setToolTipText(oldToolTip);
> 			}
> 			currentTaskHyperlink = null;
> 			currentTask = null;

Actions: View | Diff

Attachments on bug 332734: 185674 | 185680 | 185681 | 185790 | 185791 | 188115