Attachment 184535 Details for Bug 297923 – fix for Right to left issue

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] fix for Right to left issue

patch297923 (text/plain), 1.48 KB, created by elhanan Maayan

on 2010-12-04 11:50:18 EST

(hide)

Description:

Filename:

MIME Type:

Creator: elhanan Maayan

Created: 2010-12-04 11:50:18 EST

Size: 1.48 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.commons.ui
>Index: src/org/eclipse/mylyn/internal/provisional/commons/ui/dialogs/AbstractInPlaceDialog.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.commons.ui/src/org/eclipse/mylyn/internal/provisional/commons/ui/dialogs/AbstractInPlaceDialog.java,v
>retrieving revision 1.6
>diff -u -r1.6 AbstractInPlaceDialog.java
>--- src/org/eclipse/mylyn/internal/provisional/commons/ui/dialogs/AbstractInPlaceDialog.java	2 Dec 2009 22:08:16 -0000	1.6
>+++ src/org/eclipse/mylyn/internal/provisional/commons/ui/dialogs/AbstractInPlaceDialog.java	4 Dec 2010 16:48:29 -0000
>@@ -80,7 +80,8 @@
> 		} else {
> 			bounds = openControl.getBounds();
> 			Point absPosition = openControl.toDisplay(openControl.getLocation());
>-			bounds.x = absPosition.x - bounds.x;
>+
>+			bounds.x = absPosition.x - bounds.x * (Window.getDefaultOrientation() == SWT.RIGHT_TO_LEFT ? -1 : 1);
> 			bounds.y = absPosition.y - bounds.y;
> 		}
> 		this.controlBounds = bounds;
>@@ -217,8 +218,9 @@
> 				}
> 
> 				public void handleException(Throwable exception) {
>-					CommonsUiPlugin.getDefault().getLog().log(
>-							new Status(IStatus.ERROR, CommonsUiPlugin.ID_PLUGIN,
>+					CommonsUiPlugin.getDefault()
>+							.getLog()
>+							.log(new Status(IStatus.ERROR, CommonsUiPlugin.ID_PLUGIN,
> 									"Error while notifying IInPlaceCloseListener", exception)); //$NON-NLS-1$
> 				}
> 			});

Actions: View | Diff

Attachments on bug 297923: 154539 | 184464 | 184535