Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 182632 Details for
Bug 328463
[TableColumn Header] moveable columns lose and gain :hover state on single click
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read
this important communication.
[patch]
fixed previous proposed patch
328463_tablecolumn_HEAD_fixed.patch (text/plain), 3.26 KB, created by
Istvan Ballok
on 2010-11-08 11:19:07 EST
(
hide
)
Description:
fixed previous proposed patch
Filename:
MIME Type:
Creator:
Istvan Ballok
Created:
2010-11-08 11:19:07 EST
Size:
3.26 KB
patch
obsolete
>commit 7c2e24773b9f02381181e7c19be774b9c8aa08b0 >tree 904e36d5efe146eea9ff6666c049945c2d790e1f >parent 18a203a06001b7ccfebb9439a823ab5aed5c4fc7 >author Istvan Ballok <Istvan.Ballok@cas.de> 1289232945 +0100 >committer Istvan Ballok <Istvan.Ballok@cas.de> 1289232945 +0100 > > bug 328463: [TableColumn Header] moveable columns lose and gain :hover state on single click > > The problem > =========== > Moveable columns lose and gain :hover state on single click - if the theme > defines different background for the default and :hover states, > this issue causes the TableColumn to blink on click. > You can easily reproduce this behaviour in the controls demo > with business design. > > Proposed resolution > =================== > The :hover state should be removed from the TableColumn in javascript > only on the first mouse move event, after the mouse down event. > >diff --git a/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/TableColumn.js b/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/TableColumn.js >index 057ba0d..48e4382 100644 >--- a/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/TableColumn.js >+++ b/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/TableColumn.js >@@ -64,6 +64,7 @@ qx.Class.define( "org.eclipse.swt.widgets.TableColumn", { > this._sortImage.setAppearance( "table-column-sort-indicator" ); > } > this.add( this._sortImage ); >+ this.__performFakeMouseOutOnMouseMove = false; > }, > > destruct : function() { >@@ -154,7 +155,7 @@ qx.Class.define( "org.eclipse.swt.widgets.TableColumn", { > this.setCapture( true ); > evt.stopPropagation(); > evt.preventDefault(); >- widgetUtil._fakeMouseEvent( this, "mouseout" ); >+ this.__performFakeMouseOutOnMouseMove = true; > } else if( this._moveable ) { > this._inMove = true; > this.setCapture( true ); >@@ -165,7 +166,7 @@ qx.Class.define( "org.eclipse.swt.widgets.TableColumn", { > this._initialLeft = this.getLeft(); > evt.stopPropagation(); > evt.preventDefault(); >- widgetUtil._fakeMouseEvent( this, "mouseout" ); >+ this.__performFakeMouseOutOnMouseMove = true; > } > } > }, >@@ -206,7 +207,12 @@ qx.Class.define( "org.eclipse.swt.widgets.TableColumn", { > }, > > _onMouseMove : function( evt ) { >+ var widgetUtil = org.eclipse.swt.WidgetUtil; > if( this._inResize ) { >+ if (this.__performFakeMouseOutOnMouseMove) { >+ this.__performFakeMouseOutOnMouseMove = false; >+ widgetUtil._fakeMouseEvent( this, "mouseout" ); >+ } > var position = this.getLeft() + this._getResizeWidth( evt.getPageX() ); > // min column width is 5 px > if( position < this.getLeft() + 5 ) { >@@ -214,6 +220,10 @@ qx.Class.define( "org.eclipse.swt.widgets.TableColumn", { > } > this._table._showResizeLine( position ); > } else if( this._inMove ) { >+ if (this.__performFakeMouseOutOnMouseMove) { >+ this.__performFakeMouseOutOnMouseMove = false; >+ widgetUtil._fakeMouseEvent( this, "mouseout" ); >+ } > this.setLeft( evt.getPageX() - this._offsetX ); > this.addState( org.eclipse.swt.widgets.TableColumn.STATE_MOVING ); > } else {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 328463
:
181493
| 182632