Attachment 182628 Details for Bug 329637 – patch v2

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch v2

clipboard.txt (text/plain), 2.36 KB, created by Thomas Ehrnhoefer

on 2010-11-08 11:08:38 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Ehrnhoefer

Created: 2010-11-08 11:08:38 EST

Size: 2.36 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.bugzilla.core
>Index: src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaRepositoryConnector.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.core/src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaRepositoryConnector.java,v
>retrieving revision 1.185
>diff -u -r1.185 BugzillaRepositoryConnector.java
>--- src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaRepositoryConnector.java	6 Sep 2010 19:19:01 -0000	1.185
>+++ src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaRepositoryConnector.java	8 Nov 2010 16:06:56 -0000
>@@ -379,13 +379,32 @@
> 			monitor.beginTask(Messages.BugzillaRepositoryConnector_running_query, IProgressMonitor.UNKNOWN);
> 			BugzillaClient client = getClientManager().getClient(repository, new SubProgressMonitor(monitor, 1));
> 			TaskAttributeMapper mapper = getTaskDataHandler().getAttributeMapper(repository);
>+			String url = query.getUrl();
>+			String dateString = repository.getSynchronizationTimeStamp();
>+			if (dateString == null) {
>+				dateString = ""; //$NON-NLS-1$
>+			}
>+			//add advanced if not there
>+			if (!url.contains("query_format=advanced")) {
>+				if (!url.endsWith("buglist.cgi")) {
>+					url += "&";
>+				}
>+				url += "query_format=advanced";
>+			}
>+			//add to/from fields
>+			if (!url.endsWith("buglist.cgi")) {
>+				url += "&";
>+			}
>+			url += "chfieldfrom=" + URLEncoder.encode(dateString, repository.getCharacterEncoding())
>+					+ CHANGED_BUGS_CGI_ENDDATE;
>+			query.setUrl(url);
> 			boolean hitsReceived = client.getSearchHits(query, resultCollector, mapper, monitor);
>-			if (!hitsReceived) {
>-				// XXX: HACK in case of ip change bugzilla can return 0 hits
>-				// due to invalid authorization token, forcing relogin fixes
>-				client.logout(monitor);
>-				client.getSearchHits(query, resultCollector, mapper, monitor);
>-			}
>+//			if (!hitsReceived) {
>+//				// XXX: HACK in case of ip change bugzilla can return 0 hits
>+//				// due to invalid authorization token, forcing relogin fixes
>+//				client.logout(monitor);
>+//				client.getSearchHits(query, resultCollector, mapper, monitor);
>+//			}
> 
> 			if (resultCollector instanceof BugzillaTaskDataCollector) {
> 				BugzillaTaskDataCollector bCollector = (BugzillaTaskDataCollector) resultCollector;

Actions: View | Diff

Attachments on bug 329637: 182578 | 182628 | 182629