Attachment 181971 Details for Bug 328944 – WorkbenchPartReference patch v1

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] WorkbenchPartReference patch v1

bug328944-patch-v1.txt (text/plain), 1.50 KB, created by Remy Suen

on 2010-10-28 13:55:37 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Remy Suen

Created: 2010-10-28 13:55:37 EDT

Size: 1.50 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/WorkbenchPartReference.java
>===================================================================
>RCS file: /cvsroot/eclipse/e4/org.eclipse.e4.compatibility/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPartReference.java,v
>retrieving revision 1.13
>diff -u -r1.13 WorkbenchPartReference.java
>--- Eclipse UI/org/eclipse/ui/internal/WorkbenchPartReference.java	21 Sep 2010 16:34:31 -0000	1.13
>+++ Eclipse UI/org/eclipse/ui/internal/WorkbenchPartReference.java	28 Oct 2010 17:55:17 -0000
>@@ -444,10 +444,17 @@
> 				partService.showPart(part, PartState.CREATE);
> 			}
> 
>-			CompatibilityPart compatibilityPart = (CompatibilityPart) part.getObject();
>-			if (compatibilityPart != null) {
>-				legacyPart = compatibilityPart.getPart();
>-				addPropertyListeners();
>+			// check if we were actually created, it is insufficient to check
>+			// whether the 'object' feature is valid or not because it is one of
>+			// the last things to be unset during the teardown process, this
>+			// means we may return a valid workbench part even if it is actually
>+			// in the process of being destroyed, see bug 328944
>+			if (part.getWidget() != null) {
>+				CompatibilityPart compatibilityPart = (CompatibilityPart) part.getObject();
>+				if (compatibilityPart != null) {
>+					legacyPart = compatibilityPart.getPart();
>+					addPropertyListeners();
>+				}
> 			}
> 		}
> 		return legacyPart;

Actions: View | Diff

Attachments on bug 328944: 181971