Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
View | Details | Raw Unified | Return to bug 283036 | Differences between
and this patch

Collapse All | Expand All

(-)src/org/eclipse/core/internal/net/PreferenceManager.java (+12 lines)
Lines 64-69 Link Here
64
	}
64
	}
65
	
65
	
66
	/**
66
	/**
67
	 * Creates the preferences manager for the node defined by id
68
	 * in default scope.
69
	 * @param id node name for which node should be created in default scope 
70
	 * @return {@link PreferenceManager}
71
	 */
72
	public static PreferenceManager createDefaultManager(String id) {
73
		PreferenceManager manager = new PreferenceManager(id);
74
		manager.currentScope = manager.defaultScope;
75
		return manager;
76
	}
77
	
78
	/**
67
	 * Checks if preference migration was already performed.
79
	 * Checks if preference migration was already performed.
68
	 * @return <code>boolean</code>
80
	 * @return <code>boolean</code>
69
	 */
81
	 */
(-)src/org/eclipse/core/internal/net/ProxyManager.java (+27 lines)
Lines 122-127 Link Here
122
		System.arraycopy(nonProxiedHosts, 0, result, 0, nonProxiedHosts.length );
122
		System.arraycopy(nonProxiedHosts, 0, result, 0, nonProxiedHosts.length );
123
		return result;
123
		return result;
124
	}
124
	}
125
	
126
	public String[] getDefaultNonProxiedHosts() {
127
		checkMigrated();
128
		PreferenceManager defaultManager = PreferenceManager.createDefaultManager(Activator.ID);
129
		String[] defaultNonProxiedHosts = null;
130
		if (defaultNonProxiedHosts == null) {
131
			String prop = defaultManager.getString(PreferenceManager.ROOT, PREF_NON_PROXIED_HOSTS);
132
			defaultNonProxiedHosts = ProxyType.convertPropertyStringToHosts(prop);
133
		}
134
		if (defaultNonProxiedHosts.length == 0) {
135
			return defaultNonProxiedHosts;
136
		}
137
		String[] result = new String[defaultNonProxiedHosts.length];
138
		System.arraycopy(defaultNonProxiedHosts, 0, result, 0, defaultNonProxiedHosts.length);
139
		return result;
140
	}
125
141
126
	public String[] getNativeNonProxiedHosts() {
142
	public String[] getNativeNonProxiedHosts() {
127
		if (hasSystemProxies()) {
143
		if (hasSystemProxies()) {
Lines 169-174 Link Here
169
		}
185
		}
170
		return resolveType(result);
186
		return resolveType(result);
171
	}
187
	}
188
	
189
	IProxyData[] getDefaultProxyData() {
190
		checkMigrated();
191
		PreferenceManager defaultManager = PreferenceManager.createDefaultManager(Activator.ID);
192
		IProxyData[] result = new IProxyData[proxies.length];
193
		for (int i = 0; i < proxies.length; i++) {
194
			ProxyType defaultType = new ProxyType(proxies[i].getName(), defaultManager);
195
			result[i] = defaultType.getProxyData(ProxyType.DO_NOT_VERIFY);
196
		}
197
		return resolveType(result);
198
	}
172
199
173
	public IProxyData[] getNativeProxyData() {
200
	public IProxyData[] getNativeProxyData() {
174
		if (hasSystemProxies()) {
201
		if (hasSystemProxies()) {
(-)src/org/eclipse/core/internal/net/ProxySelector.java (+10 lines)
Lines 157-160 Link Here
157
		return false;
157
		return false;
158
	}
158
	}
159
159
160
	public static ProxyData[] getDefaultProxyData() {
161
		ProxyManager manager = (ProxyManager) ProxyManager.getProxyManager();
162
		return castArray(manager.getDefaultProxyData());
163
	}
164
165
	public static String[] getDefaultBypassHosts() {
166
		ProxyManager manager = (ProxyManager) ProxyManager.getProxyManager();
167
		return manager.getDefaultNonProxiedHosts();
168
	}
169
160
}
170
}
(-)src/org/eclipse/ui/internal/net/NonProxyHostsComposite.java (+18 lines)
Lines 349-352 Link Here
349
		return bypassProxyData;
349
		return bypassProxyData;
350
	}
350
	}
351
351
352
	public void performDefaults() {
353
		bypassHosts.clear();
354
		String editableProvider = getEditableProvider();
355
		String providers[] = ProxySelector.getProviders();
356
		for (int i = 0; i < providers.length; i++) {
357
			if (providers[i].equals(editableProvider)) {
358
				String[] hosts = ProxySelector.getDefaultBypassHosts();
359
				for (int j = 0; hosts != null && j < hosts.length; j++) {
360
					ProxyBypassData data = new ProxyBypassData(hosts[j], editableProvider);
361
					bypassHosts.add(data);
362
				}
363
			} else {
364
				bypassHosts.addAll(getProxyBypassData(providers[i]));
365
			}
366
		}
367
		hostsViewer.refresh();
368
	}
369
352
}
370
}
(-)src/org/eclipse/ui/internal/net/ProxyEntriesComposite.java (+19 lines)
Lines 11-16 Link Here
11
package org.eclipse.ui.internal.net;
11
package org.eclipse.ui.internal.net;
12
12
13
import java.util.ArrayList;
13
import java.util.ArrayList;
14
import java.util.Arrays;
14
import java.util.Iterator;
15
import java.util.Iterator;
15
import java.util.List;
16
import java.util.List;
16
17
Lines 327-330 Link Here
327
		}
328
		}
328
		return proxyDatas;
329
		return proxyDatas;
329
	}
330
	}
331
332
	public void performDefaults() {
333
		proxyEntries.clear();
334
		String editableProvider = getEditableProvider();
335
		String providers[] = ProxySelector.getProviders();
336
		for (int i = 0; i < providers.length; i++) {
337
			if (providers[i].equals(editableProvider)) {
338
				ProxyData[] entries = ProxySelector.getDefaultProxyData();
339
				for (int j = 0; j < entries.length; j++) {
340
					entries[j].setSource(editableProvider);
341
				}
342
				proxyEntries.addAll(Arrays.asList(entries));
343
			} else {
344
				proxyEntries.addAll(getProxyData(providers[i]));
345
			}
346
		}
347
		entriesViewer.refresh();
348
	}
330
}
349
}
(-)src/org/eclipse/ui/internal/net/ProxyPreferencePage.java (+2 lines)
Lines 110-115 Link Here
110
			index = 2;
110
			index = 2;
111
		}
111
		}
112
		providerCombo.select(index);
112
		providerCombo.select(index);
113
		proxyEntriesComposite.performDefaults();
114
		nonProxyHostsComposite.performDefaults();
113
		setProvider(ProxySelector.unlocalizeProvider(providerCombo.getItem(index)));
115
		setProvider(ProxySelector.unlocalizeProvider(providerCombo.getItem(index)));
114
	}
116
	}
115
117

Return to bug 283036