Attachment 180153 Details for Bug 326910 – Patch fixing the issue

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch fixing the issue

bug326910_rseSelection.diff.txt (text/plain), 2.14 KB, created by Martin Oberhuber

on 2010-10-04 08:31:08 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Oberhuber

Created: 2010-10-04 08:31:08 EDT

Size: 2.14 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.ui
>Index: UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java,v
>retrieving revision 1.49
>diff -u -r1.49 SystemViewPart.java
>--- UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java	24 Aug 2009 14:58:31 -0000	1.49
>+++ UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java	4 Oct 2010 12:28:13 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2002, 2009 IBM Corporation and others.
>+ * Copyright (c) 2002, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -40,6 +40,7 @@
>  * David McKnight   (IBM)        - [250417] Restore from memento flag set to false during restore on startup
>  * Martin Oberhuber (Wind River) - [286122] Avoid NPE when restoring memento
>  * David McKnight   (IBM)        - [286670] TVT35:TCT586: CHS: English Strings Found
>+ * Martin Oberhuber (Wind River) - [326910] RSE looses selection when creating a project
>  *******************************************************************************/
> 
> package org.eclipse.rse.internal.ui.view;
>@@ -231,7 +232,21 @@
> 	 */
> 	public void selectReveal(ISelection selection)
> 	{
>-		systemView.setSelection(selection, true);
>+		ISelection origSel = systemView.getSelection();
>+		if (origSel.isEmpty()) {
>+			systemView.setSelection(selection, true);
>+		} else {
>+			// bug check whether the new selection can be set,
>+			// before actually setting it. Restore old selection
>+			// if the new one does not work.
>+			systemView.setSelection(selection, false);
>+			ISelection newSel = systemView.getSelection();
>+			if (newSel.isEmpty()) {
>+				systemView.setSelection(origSel, false);
>+			} else {
>+				systemView.setSelection(newSel, true);
>+			}
>+		}
> 	}
> 
> 	/**

Actions: View | Diff

Attachments on bug 326910: 180153