Attachment 180115 Details for Bug 110684 – patch for IDEWorkbenchWindowAdvisor

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

patch for IDEWorkbenchWindowAdvisor

patch-110684.txt (text/plain), 2.17 KB, created by Edoardo Comar

on 2010-10-03 07:53:50 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Edoardo Comar

Created: 2010-10-03 07:53:50 EDT

Size: 2.17 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.ide.application
>Index: src/org/eclipse/ui/internal/ide/application/IDEWorkbenchWindowAdvisor.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchWindowAdvisor.java,v
>retrieving revision 1.16
>diff -u -r1.16 IDEWorkbenchWindowAdvisor.java
>--- src/org/eclipse/ui/internal/ide/application/IDEWorkbenchWindowAdvisor.java	26 Aug 2010 16:18:51 -0000	1.16
>+++ src/org/eclipse/ui/internal/ide/application/IDEWorkbenchWindowAdvisor.java	3 Oct 2010 11:52:33 -0000
>@@ -63,6 +63,9 @@
> import org.eclipse.ui.application.IActionBarConfigurer;
> import org.eclipse.ui.application.IWorkbenchWindowConfigurer;
> import org.eclipse.ui.application.WorkbenchWindowAdvisor;
>+import org.eclipse.ui.internal.EditorAreaHelper;
>+import org.eclipse.ui.internal.PartStack;
>+import org.eclipse.ui.internal.WorkbenchPage;
> import org.eclipse.ui.internal.ide.AboutInfo;
> import org.eclipse.ui.internal.ide.EditorAreaDropAdapter;
> import org.eclipse.ui.internal.ide.IDEInternalPreferences;
>@@ -251,6 +254,31 @@
> 		hookTitleUpdateListeners(configurer);
> 	}
> 
>+	
>+	/* 
>+	 * (non-Javadoc)
>+	 * 
>+	 * @see org.eclipse.ui.application.WorkbenchWindowAdvisor#postWindowOpen()
>+	 */
>+	public void postWindowOpen() {
>+		super.postWindowOpen();
>+		//close any empty Editor stacks that may have been left open 
>+		// https://bugs.eclipse.org/bugs/show_bug.cgi?id=110684
>+		if(getWindowConfigurer()!=null && getWindowConfigurer().getWindow()!=null && getWindowConfigurer().getWindow().getActivePage()!=null) {
>+			WorkbenchPage activePage = (WorkbenchPage) getWindowConfigurer().getWindow().getActivePage();
>+			EditorAreaHelper editorAreaHelper = activePage.getEditorPresentation();
>+			if(editorAreaHelper!=null) {
>+				ArrayList workbooks = editorAreaHelper.getWorkbooks();
>+				for (int i = 0; i < workbooks.size(); i++) {
>+					PartStack editorStack = (PartStack) workbooks.get(i);
>+					if(editorStack.getChildren().length==0) {
>+						editorStack.getContainer().remove(editorStack);
>+					}
>+				}
>+			}
>+		}
>+	}
>+	
> 	/**
> 	 * Hooks the listeners needed on the window
> 	 *

Flags:

pwebster: iplog+

Actions: View

Attachments on bug 110684: 27530 | 180115 | 182769