Attachment 179361 Details for Bug 325933 – Proposed patch and js test

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch and js test

Bug325933.patch (text/plain), 2.05 KB, created by Ivan Furnadjiev

on 2010-09-22 05:25:23 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2010-09-22 05:25:23 EDT

Size: 2.05 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/rwt/widgets/Tree.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/rwt/widgets/Tree.js,v
>retrieving revision 1.19
>diff -u -r1.19 Tree.js
>--- js/org/eclipse/rwt/widgets/Tree.js	9 Sep 2010 09:59:18 -0000	1.19
>+++ js/org/eclipse/rwt/widgets/Tree.js	22 Sep 2010 09:22:33 -0000
>@@ -292,7 +292,13 @@
>     },
> 
>     setScrollBarsVisible : function( horzVisible, vertVisible ) {
>+      if( !horzVisible ) {
>+        this._horzScrollBar.setValue( 0 );
>+      }
>       this._horzScrollBar.setVisibility( horzVisible );
>+      if( !vertVisible ) {
>+        this._vertScrollBar.setValue( 0 );
>+      }
>       this._vertScrollBar.setVisibility( vertVisible );
>       this._layoutX();
>       this._layoutY();
>#P org.eclipse.rap.rwt.q07.jstest
>Index: js/org/eclipse/rwt/test/tests/TreeTest.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt.test/org.eclipse.rap.rwt.q07.jstest/js/org/eclipse/rwt/test/tests/TreeTest.js,v
>retrieving revision 1.12
>diff -u -r1.12 TreeTest.js
>--- js/org/eclipse/rwt/test/tests/TreeTest.js	10 Sep 2010 12:11:22 -0000	1.12
>+++ js/org/eclipse/rwt/test/tests/TreeTest.js	22 Sep 2010 09:22:34 -0000
>@@ -572,6 +572,18 @@
>       assertTrue( tree._vertScrollBar.getVisibility() );
>       tree.destroy();
>     },
>+    
>+    testSetScrollBarsVisibileResetValue : function() {
>+      var testUtil = org.eclipse.rwt.test.fixture.TestUtil;
>+      var tree = this._createDefaultTree();
>+      tree.setScrollBarsVisible( true, true );      
>+      testUtil.flush();
>+      tree._horzScrollBar.setValue( 10 );
>+      tree._vertScrollBar.setValue( 10 );
>+      tree.setScrollBarsVisible( false, false );
>+      assertEquals( 0, tree._horzScrollBar.getValue() );
>+      assertEquals( 0, tree._vertScrollBar.getValue() );
>+    },
> 
>     testVerticalScrollBarLayout : function() {
>       var testUtil = org.eclipse.rwt.test.fixture.TestUtil;

Actions: View | Diff

Attachments on bug 325933: 179361