Attachment 178626 Details for Bug 320951 – Patch v02

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch v02

patch_Bug_320951_2.txt (text/plain), 1.93 KB, created by Hitesh

on 2010-09-10 11:56:42 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Hitesh

Created: 2010-09-10 11:56:42 EDT

Size: 1.93 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jface
>Index: src/org/eclipse/jface/viewers/ContentViewer.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/ContentViewer.java,v
>retrieving revision 1.16
>diff -u -r1.16 ContentViewer.java
>--- src/org/eclipse/jface/viewers/ContentViewer.java	25 May 2009 20:52:37 -0000	1.16
>+++ src/org/eclipse/jface/viewers/ContentViewer.java	10 Sep 2010 15:52:39 -0000
>@@ -262,6 +262,12 @@
>      * if required.
>      */
>     public void setInput(Object input) {
>+    	Control control = getControl();
>+		if (control == null || control.isDisposed()) {
>+			throw new IllegalStateException(
>+					"Need an underlying widget to be able to set the input." + //$NON-NLS-1$
>+							"(Has the widget been disposed?)"); //$NON-NLS-1$
>+		}
>         Assert
>                 .isTrue(getContentProvider() != null,
>                         "ContentViewer must have a content provider when input is set."); //$NON-NLS-1$
>Index: src/org/eclipse/jface/viewers/StructuredViewer.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/StructuredViewer.java,v
>retrieving revision 1.87
>diff -u -r1.87 StructuredViewer.java
>--- src/org/eclipse/jface/viewers/StructuredViewer.java	25 Jun 2010 13:02:16 -0000	1.87
>+++ src/org/eclipse/jface/viewers/StructuredViewer.java	10 Sep 2010 15:52:40 -0000
>@@ -1655,7 +1655,12 @@
> 	 * @see org.eclipse.jface.viewers.Viewer#setInput(java.lang.Object)
> 	 */
> 	public final void setInput(Object input) {
>-
>+		Control control = getControl();
>+		if (control == null || control.isDisposed()) {
>+			throw new IllegalStateException(
>+					"Need an underlying widget to be able to set the input." + //$NON-NLS-1$
>+							"(Has the widget been disposed?)"); //$NON-NLS-1$
>+		}
> 		try {
> 			//		fInChange= true;
>

Actions: View | Diff

Attachments on bug 320951: 178310 | 178626