Attachment 178388 Details for Bug 307393 – Code visibility changed

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Code visibility changed

visibility.patch (text/plain), 5.16 KB, created by Violeta Georgieva

on 2010-09-08 07:37:12 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Violeta Georgieva

Created: 2010-09-08 07:37:12 EDT

Size: 5.16 KB

patch

obsolete

>diff --git a/org.eclipse.gemini.web.core/src/main/java/org/eclipse/gemini/web/internal/url/DirTransformer.java b/org.eclipse.gemini.web.core/src/main/java/org/eclipse/gemini/web/internal/url/DirTransformer.java
>index 52b8811..dcf5c30 100644
>--- a/org.eclipse.gemini.web.core/src/main/java/org/eclipse/gemini/web/internal/url/DirTransformer.java
>+++ b/org.eclipse.gemini.web.core/src/main/java/org/eclipse/gemini/web/internal/url/DirTransformer.java
>@@ -35,14 +35,14 @@ import org.eclipse.virgo.util.io.PathReference;
>  * Files cannot be added, only changed or removed. Actual transformation of files is performed by an implementation of
>  * the {@link DirTransformerCallback} interface.
>  */
>-public class DirTransformer {
>+final class DirTransformer {
> 
>     /**
>      * Callback interface used to transform files in a directory.
>      * 
>      * @see DirTransformer
>      */
>-    public static interface DirTransformerCallback {
>+    static interface DirTransformerCallback {
> 
>         /**
>          * Transform the supplied file.
>@@ -75,7 +75,7 @@ public class DirTransformer {
>      * 
>      * @param callback the <code>DirTransformerCallback</code> to use for file transformation.
>      */
>-    public DirTransformer(DirTransformerCallback callback) {
>+    DirTransformer(DirTransformerCallback callback) {
>         if (callback == null) {
>             throw new IllegalArgumentException("Callback must not be null");
>         }
>@@ -89,7 +89,7 @@ public class DirTransformer {
>      * @param transformedUrl the {@link URL} to write the transformed directory to.
>      * @throws IOException if the directory cannot be transformed.
>      */
>-    public void transform(URL url, URL transformedUrl) throws IOException {
>+    void transform(URL url, URL transformedUrl) throws IOException {
>         transform(url, transformedUrl, false);
>     }
> 
>@@ -101,7 +101,7 @@ public class DirTransformer {
>      * @param ensureManifestIsPresent if <code>true</code> ensures that the transformed directory contains a manifest.
>      * @throws IOException if the directory cannot be transformed.
>      */
>-    public void transform(URL url, URL transformedUrl, boolean ensureManifestIsPresent) throws IOException {
>+    void transform(URL url, URL transformedUrl, boolean ensureManifestIsPresent) throws IOException {
>         PathReference fromDirectory = new PathReference(url.getPath());
>         PathReference toDirectory = new PathReference(transformedUrl.getPath());
>         transformDir(fromDirectory, toDirectory);
>diff --git a/org.eclipse.gemini.web.core/src/main/java/org/eclipse/gemini/web/internal/url/DirTransformingURLConnection.java b/org.eclipse.gemini.web.core/src/main/java/org/eclipse/gemini/web/internal/url/DirTransformingURLConnection.java
>index 6c738c3..1e0e7c5 100644
>--- a/org.eclipse.gemini.web.core/src/main/java/org/eclipse/gemini/web/internal/url/DirTransformingURLConnection.java
>+++ b/org.eclipse.gemini.web.core/src/main/java/org/eclipse/gemini/web/internal/url/DirTransformingURLConnection.java
>@@ -33,7 +33,7 @@ import org.eclipse.virgo.util.io.PathReference;
>  * 
>  * @see DirTransformer
>  */
>-public class DirTransformingURLConnection extends URLConnection {
>+final class DirTransformingURLConnection extends URLConnection {
> 
>     private static final String TEMP_DIR = "file:temp/";
> 
>@@ -55,7 +55,7 @@ public class DirTransformingURLConnection extends URLConnection {
>      *         be created.
>      * @throws URISyntaxException
>      */
>-    public DirTransformingURLConnection(URL url, DirTransformer transformer) throws MalformedURLException {
>+    DirTransformingURLConnection(URL url, DirTransformer transformer) throws MalformedURLException {
>         this(url, transformer, false);
>     }
> 
>@@ -71,7 +71,7 @@ public class DirTransformingURLConnection extends URLConnection {
>      *         be created.
>      * @throws URISyntaxException
>      */
>-    public DirTransformingURLConnection(URL url, DirTransformer transformer, boolean ensureManifestIsPresent) throws MalformedURLException {
>+    DirTransformingURLConnection(URL url, DirTransformer transformer, boolean ensureManifestIsPresent) throws MalformedURLException {
>         super(url);
>         this.transformer = transformer;
>         this.ensureManifestIsPresent = ensureManifestIsPresent;
>diff --git a/org.eclipse.gemini.web.core/src/main/java/org/eclipse/gemini/web/internal/url/WebBundleUrlStreamHandlerService.java b/org.eclipse.gemini.web.core/src/main/java/org/eclipse/gemini/web/internal/url/WebBundleUrlStreamHandlerService.java
>index 0740c22..5b73c40 100644
>--- a/org.eclipse.gemini.web.core/src/main/java/org/eclipse/gemini/web/internal/url/WebBundleUrlStreamHandlerService.java
>+++ b/org.eclipse.gemini.web.core/src/main/java/org/eclipse/gemini/web/internal/url/WebBundleUrlStreamHandlerService.java
>@@ -88,7 +88,7 @@ public final class WebBundleUrlStreamHandlerService extends AbstractURLStreamHan
> 
>         private final WebBundleUrl webBundleUrl;
> 
>-        public Callback(URL sourceURL, WebBundleUrl url, WebBundleManifestTransformer transformer) {
>+        Callback(URL sourceURL, WebBundleUrl url, WebBundleManifestTransformer transformer) {
>             this.sourceURL = sourceURL;
>             this.webBundleUrl = url;
>             this.transformer = transformer;

Flags:

glyn.normington: iplog+

Actions: View | Diff

Attachments on bug 307393: 163269 | 174009 | 174863 | 174968 | 178388 | 178591 | 178592