Attachment 178123 Details for Bug 268402 – Fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix

patch.txt (text/plain), 1.80 KB, created by Markus Keller

on 2010-09-03 03:24:09 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Markus Keller

Created: 2010-09-03 03:24:09 EDT

Size: 1.80 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.forms
>Index: src/org/eclipse/ui/forms/widgets/FormText.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.forms/src/org/eclipse/ui/forms/widgets/FormText.java,v
>retrieving revision 1.87
>diff -u -r1.87 FormText.java
>--- src/org/eclipse/ui/forms/widgets/FormText.java	25 Feb 2010 17:53:56 -0000	1.87
>+++ src/org/eclipse/ui/forms/widgets/FormText.java	3 Sep 2010 07:23:59 -0000
>@@ -17,7 +17,6 @@
> import java.util.Hashtable;
> 
> import org.eclipse.core.runtime.ListenerList;
>-
> import org.eclipse.swt.SWT;
> import org.eclipse.swt.SWTException;
> import org.eclipse.swt.accessibility.ACC;
>@@ -61,7 +60,6 @@
> import org.eclipse.swt.widgets.Menu;
> import org.eclipse.swt.widgets.MenuItem;
> import org.eclipse.swt.widgets.TypedListener;
>-
> import org.eclipse.ui.forms.HyperlinkSettings;
> import org.eclipse.ui.forms.events.HyperlinkEvent;
> import org.eclipse.ui.forms.events.IHyperlinkListener;
>@@ -1612,22 +1610,21 @@
> 
> 	private void paintFocusTransfer(IHyperlinkSegment oldLink,
> 			IHyperlinkSegment newLink) {
>-		GC gc = new GC(this);
>-		Color bg = getBackground();
>-		Color fg = getForeground();
>-		gc.setFont(getFont());
> 		if (oldLink != null) {
>-			gc.setBackground(bg);
>-			gc.setForeground(fg);
>-			oldLink.paintFocus(gc, bg, fg, false, null);
>+			Rectangle r = oldLink.getBounds();
>+			redraw(r.x, r.y, r.width, r.height, true);
>+			update();
> 		}
> 		if (newLink != null) {
>-			// ensureVisible(newLink);
>+			GC gc = new GC(this);
>+			Color bg = getBackground();
>+			Color fg = getForeground();
>+			gc.setFont(getFont());
> 			gc.setBackground(bg);
> 			gc.setForeground(fg);
> 			newLink.paintFocus(gc, bg, fg, true, null);
>+			gc.dispose();
> 		}
>-		gc.dispose();
> 	}
> 
> 	private void ensureVisible(IFocusSelectable segment) {

Actions: View | Diff

Attachments on bug 268402: 178123 | 181759