Attachment 178004 Details for Bug 322867 – commited patch V3

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] commited patch V3

patch322867V3.txt (text/plain), 2.84 KB, created by Frank Becker

on 2010-09-01 16:52:26 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frank Becker

Created: 2010-09-01 16:52:26 EDT

Size: 2.84 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.bugzilla.core
>Index: src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaUtil.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.core/src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaUtil.java,v
>retrieving revision 1.3
>diff -u -r1.3 BugzillaUtil.java
>--- src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaUtil.java	30 Aug 2010 20:07:03 -0000	1.3
>+++ src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaUtil.java	1 Sep 2010 20:49:37 -0000
>@@ -16,18 +16,19 @@
> import org.eclipse.mylyn.tasks.core.data.TaskData;
> 
> public class BugzillaUtil {
>-	public static void addAttributeIfUsed(BugzillaAttribute constant, String propertyName,
>-			TaskRepository taskRepository, TaskData existingReport, boolean createWhenNull) {
>+
>+	private static boolean getParamValue(TaskRepository taskRepository, String propertyName, boolean trueIfUndefined) {
>+		boolean result;
> 		String useParam = taskRepository.getProperty(propertyName);
>-		if (createWhenNull) {
>-			if (useParam == null || (useParam != null && useParam.equals("true"))) { //$NON-NLS-1$
>-				BugzillaTaskDataHandler.createAttribute(existingReport, constant);
>-			}
>-		} else {
>-			if (useParam != null && useParam.equals("true")) { //$NON-NLS-1$
>-				BugzillaTaskDataHandler.createAttribute(existingReport, constant);
>-			}
>+		result = trueIfUndefined ? (useParam == null || (useParam != null && useParam.equals("true"))) //$NON-NLS-1$
>+				: (useParam != null && useParam.equals("true")); //$NON-NLS-1$
>+		return result;
>+	}
> 
>+	public static void addAttributeIfUsed(BugzillaAttribute constant, String propertyName,
>+			TaskRepository taskRepository, TaskData existingReport, boolean createWhenNull) {
>+		if (getParamValue(taskRepository, propertyName, createWhenNull)) {
>+			BugzillaTaskDataHandler.createAttribute(existingReport, constant);
> 		}
> 	}
> 
>@@ -44,19 +45,11 @@
> 		if (BugzillaAttribute.QA_CONTACT.equals(tag)) {
> 			attribute.getMetaData().setKind(null);
> 		} else {
>-			String useParam = repositoryTaskData.getAttributeMapper().getTaskRepository().getProperty(propertyName);
>-			if (defaultWhenNull) {
>-				if (useParam == null || (useParam != null && useParam.equals("true"))) { //$NON-NLS-1$
>-					attribute.getMetaData().setKind(TaskAttribute.KIND_DEFAULT);
>-				} else {
>-					attribute.getMetaData().setKind(null);
>-				}
>+			if (getParamValue(repositoryTaskData.getAttributeMapper().getTaskRepository(), propertyName,
>+					defaultWhenNull)) {
>+				attribute.getMetaData().setKind(TaskAttribute.KIND_DEFAULT);
> 			} else {
>-				if (useParam != null && useParam.equals("true")) { //$NON-NLS-1$
>-					attribute.getMetaData().setKind(TaskAttribute.KIND_DEFAULT);
>-				} else {
>-					attribute.getMetaData().setKind(null);
>-				}
>+				attribute.getMetaData().setKind(null);
> 			}
> 		}
> 	}

Actions: View | Diff

Attachments on bug 322867: 177049 | 177050 | 177162 | 177163 | 178004 | 178005