Attachment 177746 Details for Bug 321295 – Updated patch against RAP 1.3

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Updated patch against RAP 1.3

clipboard.txt (text/plain), 2.01 KB, created by Ralf Sternberg

on 2010-08-30 11:58:12 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Sternberg

Created: 2010-08-30 11:58:12 EDT

Size: 2.01 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Link.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Link.js,v
>retrieving revision 1.7
>diff -u -r1.7 Link.js
>--- js/org/eclipse/swt/widgets/Link.js	5 Nov 2009 12:29:19 -0000	1.7
>+++ js/org/eclipse/swt/widgets/Link.js	30 Aug 2010 15:46:59 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2009 EclipseSource and others. All rights reserved.
>+ * Copyright (c) 2009, 2010 EclipseSource and others. All rights reserved.
>  * This program and the accompanying materials are made available under the
>  * terms of the Eclipse Public License v1.0 which accompanies this distribution,
>  * and is available at http://www.eclipse.org/legal/epl-v10.html
>@@ -149,6 +149,7 @@
>       this._removeEventListeners();
>       this._text = "";
>       this._linksCount = 0;
>+      this._currentFocusedLink = -1;
>     },
>     
>     _applyHyperlinksStyleProperties : function() {
>@@ -304,14 +305,14 @@
>       var linkElement = this.getElement();
>       if( linkElement ) {
>         var hyperlinks = linkElement.getElementsByTagName( "span" );
>-        if( this._currentFocusedLink >= 0 ) {
>+        if( this._currentFocusedLink >= 0 && this._currentFocusedLink < hyperlinks.length ) {
>           hyperlinks[ this._currentFocusedLink ].blur();
>           if( qx.core.Variant.isSet( "qx.client", "webkit" ) ) {
>             hyperlinks[ this._currentFocusedLink ].style.outline = "none";
>           }
>         }
>         this._currentFocusedLink = id;
>-        if( this._currentFocusedLink >= 0 ) {
>+        if( this._currentFocusedLink >= 0 && this._currentFocusedLink < hyperlinks.length ) {
>           hyperlinks[ this._currentFocusedLink ].focus();
>           if( qx.core.Variant.isSet( "qx.client", "webkit" ) ) {
>             hyperlinks[ this._currentFocusedLink ].style.outline = "1px dotted";

Flags:

ivan: review+

Actions: View | Diff

Attachments on bug 321295: 177707 | 177728 | 177746