Attachment 176836 Details for Bug 314744 – patch V2

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch V2

patch314744V2.txt (text/plain), 2.15 KB, created by Frank Becker

on 2010-08-17 15:41:12 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frank Becker

Created: 2010-08-17 15:41:12 EDT

Size: 2.15 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.bugzilla.core
>Index: src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaClient.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.core/src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaClient.java,v
>retrieving revision 1.254
>diff -u -r1.254 BugzillaClient.java
>--- src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaClient.java	15 Aug 2010 19:03:57 -0000	1.254
>+++ src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaClient.java	17 Aug 2010 19:31:39 -0000
>@@ -224,9 +224,11 @@
> 		CustomTransitionManager validTransitions = new CustomTransitionManager();
> 
> 		String transitionsFileName = configParameters.get(IBugzillaConstants.BUGZILLA_DESCRIPTOR_FILE);
>-		if (!validTransitions.parse(transitionsFileName)) {
>-			throw new CoreException(new Status(IStatus.WARNING, BugzillaCorePlugin.ID_PLUGIN,
>-					"Invalide Transition File Content")); //$NON-NLS-1$
>+		if (transitionsFileName != null && !transitionsFileName.equals("")) {
>+			if (!validTransitions.parse(transitionsFileName)) {
>+				throw new CoreException(new Status(IStatus.WARNING, BugzillaCorePlugin.ID_PLUGIN,
>+						"Invalide Transition File Content")); //$NON-NLS-1$
>+			}
> 		}
> 
> 	}
>@@ -711,9 +713,6 @@
> 										xmlRpcClient = new BugzillaXmlRpcClient(webLocation);
> 
> 									}
>-									if (!repositoryConfiguration.getProducts().isEmpty()) {
>-										repositoryConfiguration.setRepositoryUrl(repositoryUrl.toString());
>-									}
> 									if (xmlRpcClient != null) {
> 										xmlRpcClient.updateConfiguration(monitor, repositoryConfiguration,
> 												configParameters.get(IBugzillaConstants.BUGZILLA_DESCRIPTOR_FILE));
>@@ -721,6 +720,9 @@
> 										repositoryConfiguration.setValidTransitions(monitor,
> 												configParameters.get(IBugzillaConstants.BUGZILLA_DESCRIPTOR_FILE), null);
> 									}
>+									if (!repositoryConfiguration.getProducts().isEmpty()) {
>+										repositoryConfiguration.setRepositoryUrl(repositoryUrl.toString());
>+									}
> 
> 									if (!repositoryConfiguration.getProducts().isEmpty()) {
> 										return repositoryConfiguration;

Actions: View | Diff

Attachments on bug 314744: 176580 | 176581 | 176836 | 176837 | 179218 | 179219