Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 17613 Details for
Bug 84103
Many duplicate HTTP GETs during update operations
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read
this important communication.
[patch]
modified patch
84103.patch2 (text/plain), 2.81 KB, created by
Dorian Birsan
on 2005-02-01 16:21:57 EST
(
hide
)
Description:
modified patch
Filename:
MIME Type:
Creator:
Dorian Birsan
Created:
2005-02-01 16:21:57 EST
Size:
2.81 KB
patch
obsolete
>Index: src/org/eclipse/update/internal/core/HttpResponse.java >=================================================================== >RCS file: /home/eclipse/org.eclipse.update.core/src/org/eclipse/update/internal/core/HttpResponse.java,v >retrieving revision 1.15 >diff -u -r1.15 HttpResponse.java >--- src/org/eclipse/update/internal/core/HttpResponse.java 22 Nov 2004 23:40:12 -0000 1.15 >+++ src/org/eclipse/update/internal/core/HttpResponse.java 1 Feb 2005 21:18:07 -0000 >@@ -29,7 +29,8 @@ > > public InputStream getInputStream() throws IOException { > if (in == null && url != null) { >- connection = url.openConnection(); >+ if (connection == null) >+ connection = url.openConnection(); > if (offset > 0) > connection.setRequestProperty("Range", "bytes=" + offset + "-"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ > in = connection.getInputStream(); >@@ -43,7 +44,8 @@ > public InputStream getInputStream(IProgressMonitor monitor) > throws IOException, CoreException { > if (in == null && url != null) { >- connection = url.openConnection(); >+ if (connection == null) >+ connection = url.openConnection(); > if (offset > 0) > connection.setRequestProperty("Range", "bytes=" + offset + "-"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ > >@@ -125,6 +127,7 @@ > for (;;) { > if (monitor.isCanceled()) { > runnable.disconnect(); >+ connection = null; > break; > } > if (runnable.getInputStream() != null) { >Index: src/org/eclipse/update/internal/core/OtherResponse.java >=================================================================== >RCS file: /home/eclipse/org.eclipse.update.core/src/org/eclipse/update/internal/core/OtherResponse.java,v >retrieving revision 1.4 >diff -u -r1.4 OtherResponse.java >--- src/org/eclipse/update/internal/core/OtherResponse.java 22 Nov 2004 23:40:12 -0000 1.4 >+++ src/org/eclipse/update/internal/core/OtherResponse.java 1 Feb 2005 21:18:07 -0000 >@@ -29,7 +29,8 @@ > > public InputStream getInputStream() throws IOException { > if (in == null && url != null) { >- connection = url.openConnection(); >+ if (connection == null) >+ connection = url.openConnection(); > in = connection.getInputStream(); > this.lastModified = connection.getLastModified(); > } >@@ -41,7 +42,8 @@ > public InputStream getInputStream(IProgressMonitor monitor) > throws IOException, CoreException { > if (in == null && url != null) { >- connection = url.openConnection(); >+ if (connection == null) >+ connection = url.openConnection(); > > if (monitor != null) { > this.in = >@@ -92,6 +94,7 @@ > for (;;) { > if (monitor.isCanceled()) { > runnable.disconnect(); >+ connection = null; > break; > } > if (runnable.getInputStream() != null) {
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 84103
:
17612
| 17613