Attachment 174584 Details for Bug 312054 – Patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch

patch_312054.txt (text/plain), 3.37 KB, created by Raksha Vasisht

on 2010-07-18 15:30:43 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Raksha Vasisht

Created: 2010-07-18 15:30:43 EDT

Size: 3.37 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.ui
>Index: ui/org/eclipse/jdt/internal/ui/preferences/UserLibraryPreferencePage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/UserLibraryPreferencePage.java,v
>retrieving revision 1.54
>diff -u -r1.54 UserLibraryPreferencePage.java
>--- ui/org/eclipse/jdt/internal/ui/preferences/UserLibraryPreferencePage.java	29 Sep 2009 12:55:50 -0000	1.54
>+++ ui/org/eclipse/jdt/internal/ui/preferences/UserLibraryPreferencePage.java	18 Jul 2010 19:15:40 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2009 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -1080,6 +1081,7 @@
> 		if (dialog.open() == Window.OK) {
> 			CPUserLibraryElement newLibrary= dialog.getNewLibrary();
> 			if (element != null) {
>+				setNewParentContainer(newLibrary);
> 				fLibraryList.replaceElement(element, newLibrary);
> 			} else {
> 				fLibraryList.addElement(newLibrary);
>@@ -1089,6 +1091,22 @@
> 		}
> 	}
> 
>+	/**
>+	 * Sets the parent container as the new library element for its children.
>+	 * 
>+	 * @param newLibrary the new parent container
>+	 * @since 3.7
>+	 */
>+	private void setNewParentContainer(CPUserLibraryElement newLibrary) {
>+		CPListElement[] elements= newLibrary.getChildren();
>+		for (int i= 0; i < elements.length; i++) {
>+			Object parent= elements[i].getParentContainer();
>+			if (parent instanceof CPUserLibraryElement && !((CPUserLibraryElement)parent).equals(newLibrary)) {
>+				elements[i].setParentContainer(newLibrary);
>+			}
>+		}
>+	}
>+
> 	private void editArchiveElement(CPListElement existingElement, CPUserLibraryElement parent) {
> 		CPListElement[] elements= openExtJarFileDialog(existingElement, parent);
> 		if (elements != null) {
>Index: ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/CPListElement.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/CPListElement.java,v
>retrieving revision 1.79
>diff -u -r1.79 CPListElement.java
>--- ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/CPListElement.java	14 Feb 2009 07:57:06 -0000	1.79
>+++ ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/CPListElement.java	18 Jul 2010 19:15:40 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2009 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -394,6 +394,16 @@
> 	}
> 
> 	/**
>+	 * Sets the parent container.
>+	 * 
>+	 * @param parent the parent container
>+	 * @since 3.7
>+	 */
>+	public void setParentContainer(CPUserLibraryElement parent) {
>+		fParentContainer= parent;
>+	}
>+
>+	/**
> 	 * Notifies that an attribute has changed
> 	 *
> 	 * @param key the changed key

Flags:

daniel_megert: review-

Actions: View | Diff

Attachments on bug 312054: 174584 | 174715 | 174736