Attachment 17234 Details for Bug 77840 – Patch to "org.eclipse.ui.workbench"

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to "org.eclipse.ui.workbench"

Bug77840-org.eclipse.ui.workbench.patch (text/plain), 1.81 KB, created by Douglas Pollock

on 2005-01-18 05:36:47 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Douglas Pollock

Created: 2005-01-18 05:36:47 EST

Size: 1.81 KB

patch

obsolete

>Index: Eclipse UI/org/eclipse/ui/internal/dialogs/ProductInfoDialog.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ProductInfoDialog.java,v
>retrieving revision 1.13
>diff -u -r1.13 ProductInfoDialog.java
>--- Eclipse UI/org/eclipse/ui/internal/dialogs/ProductInfoDialog.java	23 Jun 2004 17:14:35 -0000	1.13
>+++ Eclipse UI/org/eclipse/ui/internal/dialogs/ProductInfoDialog.java	18 Jan 2005 10:28:35 -0000
>@@ -350,10 +350,17 @@
> 		Thread launcher = new Thread("About Link Launcher") {//$NON-NLS-1$
> 			public void run() {
> 				try {
>+					/*
>+					 * encoding the href as the browser does not open if there
>+					 * is a space in the url. Bug 77840
>+					 */
>+					String encodedLocalHref = urlEncodeForSpaces(localHref
>+							.toCharArray());
>+
> 					if (webBrowserOpened) {
>-						Runtime.getRuntime().exec(webBrowser + " -remote openURL(" + localHref + ")"); //$NON-NLS-1$ //$NON-NLS-2$
>+						Runtime.getRuntime().exec(webBrowser + " -remote openURL(" + encodedLocalHref + ")"); //$NON-NLS-1$ //$NON-NLS-2$ // 77840
> 					} else {
>-						Process p = openWebBrowser(localHref);
>+						Process p = openWebBrowser(encodedLocalHref); // 77840
> 						webBrowserOpened = true;
> 						try {
> 							if (p != null)
>@@ -371,6 +378,25 @@
> 		};
> 		launcher.start();
> 	}
>+}
>+
>+/**
>+ * This method encodes the url, removes the spaces from the url and replaces
>+ * the same with <code>"%20"</code>. This method is required to fix Bug
>+ * 77840.
>+ * 
>+ * @since 3.0.2
>+ */
>+private String urlEncodeForSpaces(char[] input) {
>+	StringBuffer retu = new StringBuffer(input.length);
>+	for (int i = 0; i < input.length; i++) {
>+		if (input[i] == ' ')
>+			retu.append("%20");
>+		else
>+			retu.append(input[i]);
>+	}
>+	return retu.toString();
>+
> }
> 
> /**

Actions: View | Diff

Attachments on bug 77840: 17176 | 17234