Attachment 171968 Details for Bug 315812 – Fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix

315812-patch.txt (text/plain), 1.38 KB, created by Scott Kovatch

on 2010-06-15 13:41:57 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Scott Kovatch

Created: 2010-06-15 13:41:57 EDT

Size: 1.38 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.swt
>Index: Eclipse SWT/cocoa/org/eclipse/swt/widgets/ToolItem.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/ToolItem.java,v
>retrieving revision 1.68
>diff -u -r1.68 ToolItem.java
>--- Eclipse SWT/cocoa/org/eclipse/swt/widgets/ToolItem.java	26 May 2010 17:58:53 -0000	1.68
>+++ Eclipse SWT/cocoa/org/eclipse/swt/widgets/ToolItem.java	15 Jun 2010 17:39:55 -0000
>@@ -199,10 +199,16 @@
> 				return description;
> 			}
> 		}
>-	} else if (nsAttributeName.isEqualToString (OS.NSAccessibilityTitleAttribute) || nsAttributeName.isEqualToString (OS.NSAccessibilityDescriptionAttribute)) {
>+	} else if (nsAttributeName.isEqualToString (OS.NSAccessibilityTitleAttribute)) {
>+		String accessibleText = text.length() > 0 ? text : toolTipText;
>+		if (accessibleText != null) {
>+			return NSString.stringWith(accessibleText).id;
>+		} else {
>+			return NSString.string().id;
>+		}
>+	} else if (nsAttributeName.isEqualToString (OS.NSAccessibilityHelpAttribute)) {
> 		String accessibleText = toolTipText;
>-		if (accessibleText == null || accessibleText.equals("")) accessibleText = text;
>-		if (!(accessibleText == null || accessibleText.equals(""))) {
>+		if (accessibleText != null) {
> 			return NSString.stringWith(accessibleText).id;
> 		} else {
> 			return NSString.string().id;

Actions: View | Diff

Attachments on bug 315812: 171968